Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: Source/core/animation/AnimationTimeline.cpp

Issue 1054823002: Unregister AnimationPlayer from ActiveDOMObjects on timeline deletion. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/AnimationTimeline.cpp
diff --git a/Source/core/animation/AnimationTimeline.cpp b/Source/core/animation/AnimationTimeline.cpp
index a9d7abfda6e1e39ed1396850c8a7cf600371b5d1..e490b9a0324ad01999f34d622053f8894b010561 100644
--- a/Source/core/animation/AnimationTimeline.cpp
+++ b/Source/core/animation/AnimationTimeline.cpp
@@ -77,6 +77,9 @@ AnimationTimeline::AnimationTimeline(Document* document, PassOwnPtrWillBeRawPtr<
AnimationTimeline::~AnimationTimeline()
{
+ for (const auto& player : m_players)
sof 2015/04/10 09:12:52 Why are their two loops over m_players here (and d
loyso (OOO) 2015/04/13 00:05:16 Nice to know from now! Sorry and thanks, sof!
+ player->dispose();
dstockwell 2015/04/10 11:21:34 Hmm, this should probably just move to player->tim
+
#if !ENABLE(OILPAN)
for (const auto& player : m_players)
player->timelineDestroyed();
« Source/core/animation/AnimationPlayer.cpp ('K') | « Source/core/animation/AnimationPlayer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698