Issue 1054803004: Allow entering keyword mode with space when there's inline autocompletion.

Issue 1054803004: Allow entering keyword mode with space when there's inline autocompletion. (Closed)

Created:
5 years, 8 months ago by Peter Kasting

Modified:
5 years, 8 months ago

Reviewers:
Mark P

CC:
chromium-reviews, tfarina, James Su

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Allow entering keyword mode with space when there's inline autocompletion. BUG=92133 TEST=See bug Committed: https://crrev.com/466ca18c8a7f5506b3675079e113f262e327f83e Cr-Commit-Position: refs/heads/master@{#326420}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -15 lines)			Patch
	M	chrome/browser/ui/omnibox/omnibox_edit_model.cc	View	1	3 chunks	+51 lines, -15 lines	0 comments	Download

Total messages: 7 (2 generated)

Mark P

lgtm I assume you interactively tested the behavior of escape in various contexts to see ...

5 years, 8 months ago (2015-04-22 17:35:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054803004/40001

5 years, 8 months ago (2015-04-22 23:49:57 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-23 01:42:30 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/466ca18c8a7f5506b3675079e113f262e327f83e
Cr-Commit-Position: refs/heads/master@{#326420}