chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc - Issue 1054783003: views: Access the Canvas through recorders not through PaintContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

Issue 1054783003: views: Access the Canvas through recorders not through PaintContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: uiviews-recorder: . Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

diff --git a/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc b/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

index b3cf6b4dcb119494bcb777afba719086c3dad5ec..a7af6502ee5e157670546370f86bfe63effd8fdb 100644

--- a/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

+++ b/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc

@@ -19,6 +19,7 @@

#include "third_party/skia/include/core/SkColor.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"

+#include "ui/compositor/compositing_recorder.h"

#include "ui/compositor/paint_context.h"

#include "ui/gfx/canvas.h"

#include "ui/views/background.h"

@@ -465,10 +466,8 @@ void CardUnmaskPromptViews::FadeOutView::PaintChildren(

if (opacity_ > 0.99)

return views::View::PaintChildren(context);

- gfx::Canvas* canvas = context.canvas();

- canvas->SaveLayerAlpha(0xff * opacity_);

+ ui::CompositingRecorder recorder(context, opacity_);

views::View::PaintChildren(context);

- canvas->Restore();

}

void CardUnmaskPromptViews::FadeOutView::OnPaint(gfx::Canvas* canvas) {