Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1054763003: Wrap promise implementation in a function. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Wrap promise implementation in a function. R=mvstanton@chromium.org Committed: https://crrev.com/f76d6a996f59bab32ca5e50129a8d89973ef0635 Cr-Commit-Position: refs/heads/master@{#27969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -343 lines) Patch
M src/bootstrapper.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mirror-debugger.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/promise.js View 2 chunks +334 lines, -332 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 8 months ago (2015-04-21 11:32:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054763003/1
5 years, 8 months ago (2015-04-21 11:32:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-21 12:01:42 UTC) #5
mvstanton
lgtm
5 years, 8 months ago (2015-04-21 13:54:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054763003/1
5 years, 8 months ago (2015-04-21 13:56:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 14:39:15 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:10:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f76d6a996f59bab32ca5e50129a8d89973ef0635
Cr-Commit-Position: refs/heads/master@{#27969}

Powered by Google App Engine
This is Rietveld 408576698