Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1054753003: Cleanup: Remove ppapi_internal.gyp from gyp_remaining target. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove ppapi_internal.gyp from gyp_remaining target. It is already done. BUG=461019 R=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/79ef072dd9082a432308e55a4adc93848df3449d Cr-Commit-Position: refs/heads/master@{#323884}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rm wildcard #

Patch Set 3 : fix android gn #

Patch Set 4 : ppapi_example_ #

Patch Set 5 : REBASE - why clobber isn't working? #

Patch Set 6 : ppapi_tests is not a unittests target #

Patch Set 7 : what's up with the * wildcar? #

Patch Set 8 : lets test with only one ppapi example #

Patch Set 9 : audio_input #

Patch Set 10 : c_stub #

Patch Set 11 : cc and compositor #

Patch Set 12 : crxfs, enumerate_devices and file_chooser #

Patch Set 13 : flash_topmost, gamepad, gles2 and gles2_spinning_cube #

Patch Set 14 : graphics_2d, ime, input and media_stream #

Patch Set 15 : mouse_cursor, lock, paint_manager, post_message, printing, scaling #

Patch Set 16 : everything but skeleton #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -6 lines) Patch
M BUILD.gn View 1 2 2 chunks +56 lines, -2 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +33 lines, -4 lines 0 comments Download

Messages

Total messages: 32 (11 generated)
tfarina
PTAL! https://codereview.chromium.org/1054753003/diff/1/build/gn_migration.gypi File build/gn_migration.gypi (right): https://codereview.chromium.org/1054753003/diff/1/build/gn_migration.gypi#newcode452 build/gn_migration.gypi:452: '../third_party/webrtc/tools/tools.gyp:frame_analyzer', Sorry, this got reverted today, due to ...
5 years, 8 months ago (2015-04-01 22:33:00 UTC) #1
Dirk Pranke
In order to be able to actually remove this, we need expand out that wildcard ...
5 years, 8 months ago (2015-04-01 22:43:22 UTC) #2
Dirk Pranke
On 2015/04/01 22:43:22, Dirk Pranke wrote: > In order to be able to actually remove ...
5 years, 8 months ago (2015-04-01 22:44:09 UTC) #3
tfarina
Something like I did in patch set 2?
5 years, 8 months ago (2015-04-01 22:56:33 UTC) #4
Dirk Pranke
On 2015/04/01 22:56:33, tfarina wrote: > Something like I did in patch set 2? No, ...
5 years, 8 months ago (2015-04-01 23:01:33 UTC) #5
tfarina
Another look?
5 years, 8 months ago (2015-04-01 23:10:12 UTC) #6
Dirk Pranke
lgtm, thanks! That's what I was going for.
5 years, 8 months ago (2015-04-02 01:25:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054753003/60001
5 years, 8 months ago (2015-04-02 01:32:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/12273)
5 years, 8 months ago (2015-04-02 02:46:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054753003/60001
5 years, 8 months ago (2015-04-02 02:48:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/12305)
5 years, 8 months ago (2015-04-02 03:46:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054753003/60001
5 years, 8 months ago (2015-04-02 18:45:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/12607)
5 years, 8 months ago (2015-04-02 19:54:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054753003/80001
5 years, 8 months ago (2015-04-03 00:52:44 UTC) #22
tfarina
Dirk, any idea what I'm doing wrong? Sigh!!
5 years, 8 months ago (2015-04-03 03:54:31 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/12757)
5 years, 8 months ago (2015-04-03 06:03:07 UTC) #25
Dirk Pranke
On 2015/04/03 03:54:31, tfarina wrote: > Dirk, any idea what I'm doing wrong? weird, for ...
5 years, 8 months ago (2015-04-03 17:30:27 UTC) #26
tfarina
Turns out depending on ppapi_example_skeleton was the problem. That target was making gn_all into a ...
5 years, 8 months ago (2015-04-04 18:45:07 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054753003/300001
5 years, 8 months ago (2015-04-04 18:45:19 UTC) #30
commit-bot: I haz the power
Committed patchset #16 (id:300001)
5 years, 8 months ago (2015-04-04 20:17:07 UTC) #31
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 20:18:00 UTC) #32
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/79ef072dd9082a432308e55a4adc93848df3449d
Cr-Commit-Position: refs/heads/master@{#323884}

Powered by Google App Engine
This is Rietveld 408576698