Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2812)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index b3d43716390eb73324f2ef1d9f5f15116004886d..3189c5d35dbe8d4e87e8fdc58b98c11a528dc9c0 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -33,7 +33,7 @@ static void AddPattern(URLPatternSet* extent, const std::string& pattern) {
extent->AddPattern(URLPattern(schemes, pattern));
}
-size_t IndexOf(const std::vector<string16>& warnings,
+size_t IndexOf(const std::vector<base::string16>& warnings,
const std::string& warning) {
for (size_t i = 0; i < warnings.size(); ++i) {
if (warnings[i] == ASCIIToUTF16(warning))
@@ -43,7 +43,7 @@ size_t IndexOf(const std::vector<string16>& warnings,
return warnings.size();
}
-bool Contains(const std::vector<string16>& warnings,
+bool Contains(const std::vector<base::string16>& warnings,
const std::string& warning) {
return IndexOf(warnings, warning) != warnings.size();
}
@@ -875,7 +875,7 @@ TEST(PermissionsTest, GetWarningMessages_ManyHosts) {
scoped_refptr<Extension> extension;
extension = LoadManifest("permissions", "many-hosts.json");
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
ASSERT_EQ(1u, warnings.size());
EXPECT_EQ("Access your data on encrypted.google.com and www.google.com",
@@ -887,7 +887,7 @@ TEST(PermissionsTest, GetWarningMessages_Plugins) {
scoped_refptr<PermissionSet> permissions;
extension = LoadManifest("permissions", "plugins.json");
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
// We don't parse the plugins key on Chrome OS, so it should not ask for any
// permissions.
@@ -908,7 +908,7 @@ TEST(PermissionsTest, GetWarningMessages_AudioVideo) {
PermissionSet* set =
const_cast<PermissionSet*>(
extension->GetActivePermissions().get());
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
provider->GetWarningMessages(set, extension->GetType());
EXPECT_FALSE(Contains(warnings, "Use your microphone"));
EXPECT_FALSE(Contains(warnings, "Use your camera"));
@@ -950,7 +950,7 @@ TEST(PermissionsTest, GetWarningMessages_DeclarativeWebRequest) {
LoadManifest("permissions", "web_request_com_host_permissions.json");
const PermissionMessageProvider* provider = PermissionMessageProvider::Get();
const PermissionSet* set = extension->GetActivePermissions().get();
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
provider->GetWarningMessages(set, extension->GetType());
EXPECT_TRUE(Contains(warnings, "Block parts of web pages"));
EXPECT_FALSE(Contains(warnings, "Access your data on all websites"));
@@ -971,7 +971,7 @@ TEST(PermissionsTest, GetWarningMessages_Serial) {
EXPECT_TRUE(extension->is_platform_app());
EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSerial));
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
EXPECT_TRUE(
Contains(warnings, "Use serial devices attached to your computer"));
@@ -985,7 +985,7 @@ TEST(PermissionsTest, GetWarningMessages_Socket_AnyHost) {
LoadManifest("permissions", "socket_any_host.json");
EXPECT_TRUE(extension->is_platform_app());
EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSocket));
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
EXPECT_EQ(1u, warnings.size());
EXPECT_TRUE(Contains(warnings, "Exchange data with any computer "
@@ -999,7 +999,7 @@ TEST(PermissionsTest, GetWarningMessages_Socket_OneDomainTwoHostnames) {
LoadManifest("permissions", "socket_one_domain_two_hostnames.json");
EXPECT_TRUE(extension->is_platform_app());
EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSocket));
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
// Verify the warnings, including support for unicode characters, the fact
@@ -1025,7 +1025,7 @@ TEST(PermissionsTest, GetWarningMessages_Socket_TwoDomainsOneHostname) {
LoadManifest("permissions", "socket_two_domains_one_hostname.json");
EXPECT_TRUE(extension->is_platform_app());
EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSocket));
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
// Verify the warnings, including the fact that domain host warnings come
@@ -1047,7 +1047,7 @@ TEST(PermissionsTest, GetWarningMessages_PlatformApppHosts) {
extension = LoadManifest("permissions", "platform_app_hosts.json");
EXPECT_TRUE(extension->is_platform_app());
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
ASSERT_EQ(0u, warnings.size());
@@ -1452,7 +1452,7 @@ TEST(PermissionsTest, SyncFileSystemPermission) {
apis.insert(APIPermission::kSyncFileSystem);
EXPECT_TRUE(extension->is_platform_app());
EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSyncFileSystem));
- std::vector<string16> warnings =
+ std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
EXPECT_TRUE(Contains(warnings, "Store data in your Google Drive account"));
ASSERT_EQ(1u, warnings.size());

Powered by Google App Engine
This is Rietveld 408576698