chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

diff --git a/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc b/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

index 9e144cad7ce115772c184c685eda4c6d7b1cf8fe..9adae299a73ab15beca4666c1769f2904bbd600d 100644

--- a/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

+++ b/chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc

@@ -40,8 +40,7 @@ NaClModulesHandler::NaClModulesHandler() {

NaClModulesHandler::~NaClModulesHandler() {

}

-bool NaClModulesHandler::Parse(Extension* extension,

- string16* error) {

+bool NaClModulesHandler::Parse(Extension* extension, base::string16* error) {

const base::ListValue* list_value = NULL;

if (!extension->manifest()->GetList(keys::kNaClModules, &list_value)) {

*error = ASCIIToUTF16(errors::kInvalidNaClModules);