Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: chrome/common/extensions/permissions/settings_override_permission_unittest.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // These tests make sure SettingsOverridePermission values are set correctly. 5 // These tests make sure SettingsOverridePermission values are set correctly.
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 return LoadAndExpectSuccess(manifest); 59 return LoadAndExpectSuccess(manifest);
60 } 60 }
61 }; 61 };
62 62
63 TEST_F(SettingsOverridePermissionTest, HomePage) { 63 TEST_F(SettingsOverridePermissionTest, HomePage) {
64 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage)); 64 scoped_refptr<Extension> extension(GetPermissionSet(kHomepage));
65 scoped_refptr<const PermissionSet> permission_set( 65 scoped_refptr<const PermissionSet> permission_set(
66 extension->GetActivePermissions()); 66 extension->GetActivePermissions());
67 67
68 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 68 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
69 std::vector<string16> warnings = 69 std::vector<base::string16> warnings =
70 PermissionsData::GetPermissionMessageStrings(extension.get()); 70 PermissionsData::GetPermissionMessageStrings(extension.get());
71 ASSERT_EQ(1u, warnings.size()); 71 ASSERT_EQ(1u, warnings.size());
72 EXPECT_EQ("Change your home page to: google.com/", 72 EXPECT_EQ("Change your home page to: google.com/",
73 UTF16ToUTF8(warnings[0])); 73 UTF16ToUTF8(warnings[0]));
74 74
75 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 75 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
76 EXPECT_FALSE(permission_set->HasAPIPermission( 76 EXPECT_FALSE(permission_set->HasAPIPermission(
77 APIPermission::kSearchProvider)); 77 APIPermission::kSearchProvider));
78 } 78 }
79 79
80 TEST_F(SettingsOverridePermissionTest, SartupPages) { 80 TEST_F(SettingsOverridePermissionTest, SartupPages) {
81 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages)); 81 scoped_refptr<Extension> extension(GetPermissionSet(kStartupPages));
82 scoped_refptr<const PermissionSet> permission_set( 82 scoped_refptr<const PermissionSet> permission_set(
83 extension->GetActivePermissions()); 83 extension->GetActivePermissions());
84 84
85 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 85 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
86 std::vector<string16> warnings = 86 std::vector<base::string16> warnings =
87 PermissionsData::GetPermissionMessageStrings(extension.get()); 87 PermissionsData::GetPermissionMessageStrings(extension.get());
88 ASSERT_EQ(1u, warnings.size()); 88 ASSERT_EQ(1u, warnings.size());
89 EXPECT_EQ("Change your start page to: startup.com/startup.html", 89 EXPECT_EQ("Change your start page to: startup.com/startup.html",
90 UTF16ToUTF8(warnings[0])); 90 UTF16ToUTF8(warnings[0]));
91 91
92 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 92 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
93 EXPECT_FALSE(permission_set->HasAPIPermission( 93 EXPECT_FALSE(permission_set->HasAPIPermission(
94 APIPermission::kSearchProvider)); 94 APIPermission::kSearchProvider));
95 } 95 }
96 96
97 TEST_F(SettingsOverridePermissionTest, SearchSettings) { 97 TEST_F(SettingsOverridePermissionTest, SearchSettings) {
98 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider)); 98 scoped_refptr<Extension> extension(GetPermissionSet(kSearchProvider));
99 scoped_refptr<const PermissionSet> permission_set( 99 scoped_refptr<const PermissionSet> permission_set(
100 extension->GetActivePermissions()); 100 extension->GetActivePermissions());
101 101
102 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 102 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
103 std::vector<string16> warnings = 103 std::vector<base::string16> warnings =
104 PermissionsData::GetPermissionMessageStrings(extension.get()); 104 PermissionsData::GetPermissionMessageStrings(extension.get());
105 ASSERT_EQ(1u, warnings.size()); 105 ASSERT_EQ(1u, warnings.size());
106 EXPECT_EQ("Change your search settings to: google.com", 106 EXPECT_EQ("Change your search settings to: google.com",
107 UTF16ToUTF8(warnings[0])); 107 UTF16ToUTF8(warnings[0]));
108 108
109 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 109 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kHomepage));
110 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 110 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
111 } 111 }
112 112
113 TEST_F(SettingsOverridePermissionTest, All) { 113 TEST_F(SettingsOverridePermissionTest, All) {
(...skipping 15 matching lines...) Expand all
129 129
130 130
131 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider)); 131 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kSearchProvider));
132 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage)); 132 EXPECT_TRUE(permission_set->HasAPIPermission(APIPermission::kHomepage));
133 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages)); 133 EXPECT_FALSE(permission_set->HasAPIPermission(APIPermission::kStartupPages));
134 } 134 }
135 135
136 } // namespace 136 } // namespace
137 137
138 } // namespace extensions 138 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698