Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: chrome/common/extensions/manifest_handlers/app_isolation_info.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h" 5 #include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/strings/string16.h" 8 #include "base/strings/string16.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 20 matching lines...) Expand all
31 extension->GetManifestData(keys::kIsolation)); 31 extension->GetManifestData(keys::kIsolation));
32 return info ? info->has_isolated_storage : false; 32 return info ? info->has_isolated_storage : false;
33 } 33 }
34 34
35 AppIsolationHandler::AppIsolationHandler() { 35 AppIsolationHandler::AppIsolationHandler() {
36 } 36 }
37 37
38 AppIsolationHandler::~AppIsolationHandler() { 38 AppIsolationHandler::~AppIsolationHandler() {
39 } 39 }
40 40
41 bool AppIsolationHandler::Parse(Extension* extension, string16* error) { 41 bool AppIsolationHandler::Parse(Extension* extension, base::string16* error) {
42 // Platform apps always get isolated storage. 42 // Platform apps always get isolated storage.
43 if (extension->is_platform_app()) { 43 if (extension->is_platform_app()) {
44 extension->SetManifestData(keys::kIsolation, new AppIsolationInfo(true)); 44 extension->SetManifestData(keys::kIsolation, new AppIsolationInfo(true));
45 return true; 45 return true;
46 } 46 }
47 47
48 // Other apps only get it if it is requested _and_ experimental APIs are 48 // Other apps only get it if it is requested _and_ experimental APIs are
49 // enabled. 49 // enabled.
50 if (!extension->is_app() || 50 if (!extension->is_app() ||
51 !PermissionsData::GetInitialAPIPermissions(extension)->count( 51 !PermissionsData::GetInitialAPIPermissions(extension)->count(
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 89
90 bool AppIsolationHandler::AlwaysParseForType(Manifest::Type type) const { 90 bool AppIsolationHandler::AlwaysParseForType(Manifest::Type type) const {
91 return type == Manifest::TYPE_PLATFORM_APP; 91 return type == Manifest::TYPE_PLATFORM_APP;
92 } 92 }
93 93
94 const std::vector<std::string> AppIsolationHandler::Keys() const { 94 const std::vector<std::string> AppIsolationHandler::Keys() const {
95 return SingleKey(keys::kIsolation); 95 return SingleKey(keys::kIsolation);
96 } 96 }
97 97
98 } // namespace extensions 98 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698