Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/common/extensions/command.h

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_COMMAND_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_COMMAND_H_
6 #define CHROME_COMMON_EXTENSIONS_COMMAND_H_ 6 #define CHROME_COMMON_EXTENSIONS_COMMAND_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
12 #include "ui/base/accelerators/accelerator.h" 12 #include "ui/base/accelerators/accelerator.h"
13 13
14 namespace base { 14 namespace base {
15 class DictionaryValue; 15 class DictionaryValue;
16 } 16 }
17 17
18 namespace extensions { 18 namespace extensions {
19 class Extension; 19 class Extension;
20 } 20 }
21 21
22 namespace extensions { 22 namespace extensions {
23 23
24 class Command { 24 class Command {
25 public: 25 public:
26 Command(); 26 Command();
27 Command(const std::string& command_name, 27 Command(const std::string& command_name,
28 const string16& description, 28 const base::string16& description,
29 const std::string& accelerator, 29 const std::string& accelerator,
30 bool global); 30 bool global);
31 ~Command(); 31 ~Command();
32 32
33 // The platform value for the Command. 33 // The platform value for the Command.
34 static std::string CommandPlatform(); 34 static std::string CommandPlatform();
35 35
36 // Parse a string as an accelerator. If the accelerator is unparsable then 36 // Parse a string as an accelerator. If the accelerator is unparsable then
37 // a generic ui::Accelerator object will be returns (with key_code Unknown). 37 // a generic ui::Accelerator object will be returns (with key_code Unknown).
38 static ui::Accelerator StringToAccelerator(const std::string& accelerator, 38 static ui::Accelerator StringToAccelerator(const std::string& accelerator,
39 const std::string& command_name); 39 const std::string& command_name);
40 40
41 // Returns the string representation of an accelerator without localizing the 41 // Returns the string representation of an accelerator without localizing the
42 // shortcut text (like accelerator::GetShortcutText() does). 42 // shortcut text (like accelerator::GetShortcutText() does).
43 static std::string AcceleratorToString(const ui::Accelerator& accelerator); 43 static std::string AcceleratorToString(const ui::Accelerator& accelerator);
44 44
45 // Parse the command. 45 // Parse the command.
46 bool Parse(const base::DictionaryValue* command, 46 bool Parse(const base::DictionaryValue* command,
47 const std::string& command_name, 47 const std::string& command_name,
48 int index, 48 int index,
49 string16* error); 49 base::string16* error);
50 50
51 // Convert a Command object from |extension| to a DictionaryValue. 51 // Convert a Command object from |extension| to a DictionaryValue.
52 // |active| specifies whether the command is active or not. 52 // |active| specifies whether the command is active or not.
53 base::DictionaryValue* ToValue( 53 base::DictionaryValue* ToValue(
54 const Extension* extension, bool active) const; 54 const Extension* extension, bool active) const;
55 55
56 // Accessors: 56 // Accessors:
57 const std::string& command_name() const { return command_name_; } 57 const std::string& command_name() const { return command_name_; }
58 const ui::Accelerator& accelerator() const { return accelerator_; } 58 const ui::Accelerator& accelerator() const { return accelerator_; }
59 const string16& description() const { return description_; } 59 const base::string16& description() const { return description_; }
60 bool global() const { return global_; } 60 bool global() const { return global_; }
61 61
62 // Setter: 62 // Setter:
63 void set_accelerator(ui::Accelerator accelerator) { 63 void set_accelerator(ui::Accelerator accelerator) {
64 accelerator_ = accelerator; 64 accelerator_ = accelerator;
65 } 65 }
66 void set_global(bool global) { 66 void set_global(bool global) {
67 global_ = global; 67 global_ = global;
68 } 68 }
69 69
70 private: 70 private:
71 std::string command_name_; 71 std::string command_name_;
72 ui::Accelerator accelerator_; 72 ui::Accelerator accelerator_;
73 string16 description_; 73 base::string16 description_;
74 bool global_; 74 bool global_;
75 }; 75 };
76 76
77 // A mapping of command name (std::string) to a command object. 77 // A mapping of command name (std::string) to a command object.
78 typedef std::map<std::string, Command> CommandMap; 78 typedef std::map<std::string, Command> CommandMap;
79 79
80 } // namespace extensions 80 } // namespace extensions
81 81
82 #endif // CHROME_COMMON_EXTENSIONS_COMMAND_H_ 82 #endif // CHROME_COMMON_EXTENSIONS_COMMAND_H_
OLDNEW
« no previous file with comments | « chrome/common/extensions/api/url_handlers/url_handlers_parser.cc ('k') | chrome/common/extensions/command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698