Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: chrome/common/extensions/api/sockets/sockets_manifest_handler.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/api/sockets/sockets_manifest_handler.h" 5 #include "chrome/common/extensions/api/sockets/sockets_manifest_handler.h"
6 6
7 #include "chrome/common/extensions/api/sockets/sockets_manifest_data.h" 7 #include "chrome/common/extensions/api/sockets/sockets_manifest_data.h"
8 #include "chrome/common/extensions/api/sockets/sockets_manifest_permission.h" 8 #include "chrome/common/extensions/api/sockets/sockets_manifest_permission.h"
9 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
10 #include "extensions/common/manifest_constants.h" 10 #include "extensions/common/manifest_constants.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 SocketsManifestHandler::SocketsManifestHandler() {} 14 SocketsManifestHandler::SocketsManifestHandler() {}
15 15
16 SocketsManifestHandler::~SocketsManifestHandler() {} 16 SocketsManifestHandler::~SocketsManifestHandler() {}
17 17
18 bool SocketsManifestHandler::Parse(Extension* extension, string16* error) { 18 bool SocketsManifestHandler::Parse(Extension* extension,
19 base::string16* error) {
19 const base::Value* sockets = NULL; 20 const base::Value* sockets = NULL;
20 CHECK(extension->manifest()->Get(manifest_keys::kSockets, &sockets)); 21 CHECK(extension->manifest()->Get(manifest_keys::kSockets, &sockets));
21 scoped_ptr<SocketsManifestData> data = 22 scoped_ptr<SocketsManifestData> data =
22 SocketsManifestData::FromValue(*sockets, error); 23 SocketsManifestData::FromValue(*sockets, error);
23 if (!data) 24 if (!data)
24 return false; 25 return false;
25 26
26 extension->SetManifestData(manifest_keys::kSockets, data.release()); 27 extension->SetManifestData(manifest_keys::kSockets, data.release());
27 return true; 28 return true;
28 } 29 }
29 30
30 ManifestPermission* SocketsManifestHandler::CreatePermission() { 31 ManifestPermission* SocketsManifestHandler::CreatePermission() {
31 return new SocketsManifestPermission(); 32 return new SocketsManifestPermission();
32 } 33 }
33 34
34 ManifestPermission* SocketsManifestHandler::CreateInitialRequiredPermission( 35 ManifestPermission* SocketsManifestHandler::CreateInitialRequiredPermission(
35 const Extension* extension) { 36 const Extension* extension) {
36 SocketsManifestData* data = SocketsManifestData::Get(extension); 37 SocketsManifestData* data = SocketsManifestData::Get(extension);
37 if (data) 38 if (data)
38 return data->permission()->Clone(); 39 return data->permission()->Clone();
39 return NULL; 40 return NULL;
40 } 41 }
41 42
42 const std::vector<std::string> SocketsManifestHandler::Keys() const { 43 const std::vector<std::string> SocketsManifestHandler::Keys() const {
43 return SingleKey(manifest_keys::kSockets); 44 return SingleKey(manifest_keys::kSockets);
44 } 45 }
45 46
46 } // namespace extensions 47 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698