Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1054723002: Revert of Implement IPC::ParamTraits<mojo::MessagePipeHandle> (Closed)

Created:
5 years, 8 months ago by mfomitchev1
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement IPC::ParamTraits<mojo::MessagePipeHandle> (patchset #3 id:40001 of https://codereview.chromium.org/1051443003/) Reason for revert: Broke XP Tests (1): https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/36680/steps/ipc_mojo_unittests/logs/IPCChannelMojoTest.ParamTraitInvalidMesssagePipe https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/36680/steps/ipc_mojo_unittests/logs/IPCChannelMojoTest.ParamTraitValidMesssagePipe Original issue's description: > Implement IPC::ParamTraits<mojo::MessagePipeHandle> > > This allows MessagePipeHandle to be an IPC message member. > Note that this assumes underlying channel being a ChannelMojo > and can be used in content/ only after ChannelMojo settles. > > BUG=448190 > TEST=IPCChannelMojoTest.ParamTrait* > R=viettrungluu@chromium.org > > Committed: https://crrev.com/5656ae68841a3e3ddaac75cf2983d9052d71d0d5 > Cr-Commit-Position: refs/heads/master@{#323265} TBR=viettrungluu@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448190 Committed: https://crrev.com/5b96979eb9c969061b94c5130c7214ca19bb7da3 Cr-Commit-Position: refs/heads/master@{#323322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -190 lines) Patch
M ipc/mojo/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 2 chunks +0 lines, -114 lines 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ipc/mojo/ipc_mojo_param_traits.h View 1 chunk +0 lines, -30 lines 0 comments Download
D ipc/mojo/ipc_mojo_param_traits.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mfomitchev1
Created Revert of Implement IPC::ParamTraits<mojo::MessagePipeHandle>
5 years, 8 months ago (2015-04-01 20:36:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054723002/1
5 years, 8 months ago (2015-04-01 20:36:29 UTC) #2
Hajime Morrita
On 2015/04/01 20:36:29, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-01 20:37:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 20:38:06 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 20:38:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b96979eb9c969061b94c5130c7214ca19bb7da3
Cr-Commit-Position: refs/heads/master@{#323322}

Powered by Google App Engine
This is Rietveld 408576698