Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: tests/CodexTest.cpp

Issue 1054673002: Ico test with embedded png (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Useful comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « resources/google_chrome.ico ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/CodexTest.cpp
diff --git a/tests/CodexTest.cpp b/tests/CodexTest.cpp
index f4ed0e8b02858bceb343fbe5092573c4643a9a83..1689bafd33f1e119fb42fa854fde1ce04372e6c1 100644
--- a/tests/CodexTest.cpp
+++ b/tests/CodexTest.cpp
@@ -77,7 +77,11 @@ DEF_TEST(Codec, r) {
check(r, "randPixels.bmp", SkISize::Make(8, 8), true);
// ICO
+ // These two tests examine interestingly different behavior:
+ // Decodes an embedded BMP image
check(r, "color_wheel.ico", SkISize::Make(128, 128), true);
scroggo 2015/04/01 18:28:21 Sorry; you had a conflict with my change that just
+ // Decodes an embedded PNG image
+ check(r, "google_chrome.ico", SkISize::Make(256, 256), true);
// PNG
check(r, "arrow.png", SkISize::Make(187, 312), true);
« no previous file with comments | « resources/google_chrome.ico ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698