Ico test with embedded png

Ico test with embedded png

BUG=skia:3257
Committed: https://skia.googlesource.com/skia/+/68b204e61ceb0217bd7ba3a79ce11facfb61901b

[msarett, 2015-04-01 18:10:23]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2015-04-01 18:10:24]

I verified that CodexTest still passes with the addition of the new test case.

[scroggo, 2015-04-01 18:16:26]

lgtm

https://codereview.chromium.org/1054673002/diff/1/tests/CodexTest.cpp
File tests/CodexTest.cpp (right):

https://codereview.chromium.org/1054673002/diff/1/tests/CodexTest.cpp#newcode81
tests/CodexTest.cpp:81: check(r, "google_chrome.ico", SkISize::Make(256, 256),
true);
Maybe add a comment that these tests are interestingly different because one is
an embedded BMP and the other is an embedded ICO.

[msarett, 2015-04-01 18:23:41]

The CQ bit was checked by msarett@google.com

[msarett, 2015-04-01 18:23:41]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1054673002/#ps20001
(title: "Useful comments")

[commit-bot: I haz the power, 2015-04-01 18:24:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054673002/20001

[scroggo, 2015-04-01 18:28:21]

https://codereview.chromium.org/1054673002/diff/20001/tests/CodexTest.cpp
File tests/CodexTest.cpp (right):

https://codereview.chromium.org/1054673002/diff/20001/tests/CodexTest.cpp#new...
tests/CodexTest.cpp:82: check(r, "color_wheel.ico", SkISize::Make(128, 128),
true);
Sorry; you had a conflict with my change that just went in.

canRewind is now always true, so I removed it. Now the boolean variable is
supportsScanlineDecoding, which is false for ICO, so these should both be false.

[commit-bot: I haz the power, 2015-04-01 18:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-01 18:29:25]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[msarett, 2015-04-01 18:32:15]

The CQ bit was checked by msarett@google.com

[msarett, 2015-04-01 18:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1054673002/#ps40001
(title: "Merge with latest")

[commit-bot: I haz the power, 2015-04-01 18:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054673002/40001

[commit-bot: I haz the power, 2015-04-01 19:09:26]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/68b204e61ceb0217bd7ba3a79ce11facfb61901b