Implement Permission change observing in Blink.

Implement Permission change observing in Blink.

This is going to require a Chromium CL that will plumb between the mojo
service and Blink.

BUG=437770
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192988

[mlamouri (slow - plz ping), 2015-04-01 17:28:14]

mlamouri@chromium.org changed reviewers:
+ avayvod@chromium.org, miguelg@chromium.org

[Miguel Garcia, 2015-04-01 17:41:51]

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.cpp (right):

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.cpp:20: // TODO(mlamouri): move that
to a common place.
nit: move *this*

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.cpp:23: if
(executionContext->isDocument()) {
this might sound stupid but why do we have two possible permission clients? why
not use Platform::current()->permissionClient() always?

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.h (left):

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.h:25: , public
ContextLifecycleObserver {
why this change?

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/Permissions.cpp (right):

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/Permissions.cpp:67: // The only "userVisible" push is
supported for now.
nit: remove "The"

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/Permissions.cpp:72: type =
WebPermissionTypePushNotifications;
so we still have WebPermissionTypePushNotifications value?

[mlamouri (slow - plz ping), 2015-04-01 17:53:11]

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.cpp (right):

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.cpp:20: // TODO(mlamouri): move that
to a common place.
On 2015/04/01 at 17:41:50, Miguel Garcia wrote:
> nit: move *this*

Done.

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.cpp:23: if
(executionContext->isDocument()) {
On 2015/04/01 at 17:41:51, Miguel Garcia wrote:
> this might sound stupid but why do we have two possible permission clients?
why not use Platform::current()->permissionClient() always?

The client associated with the frame will talk to a mojo pipe associated with
RenderFrameHost, which gives us a WebContent. Platform::current() wouldn't allow
you to have any WebContents information :(

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/PermissionStatus.h (left):

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/PermissionStatus.h:25: , public
ContextLifecycleObserver {
On 2015/04/01 at 17:41:51, Miguel Garcia wrote:
> why this change?

ActiveDOMObject are objects that shouldn't be deleted even if no one keep a
reference on them, because they do things in the background. With the change
event, a script might not keep a reference on the object but still print things
or modify the DOM when a change happens. Also, I need to know when the object
should "stop" in order to unsubscribe. Otherwise, Chrome will crash trying to
notify a dead object

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
File Source/modules/permissions/Permissions.cpp (right):

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/Permissions.cpp:67: // The only "userVisible" push is
supported for now.
On 2015/04/01 at 17:41:51, Miguel Garcia wrote:
> nit: remove "The"

Done.

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/Permissions.cpp:67: // The only "userVisible" push is
supported for now.
On 2015/04/01 at 17:41:51, Miguel Garcia wrote:
> nit: remove "The"

Done.

https://codereview.chromium.org/1054663002/diff/1/Source/modules/permissions/...
Source/modules/permissions/Permissions.cpp:72: type =
WebPermissionTypePushNotifications;
On 2015/04/01 at 17:41:51, Miguel Garcia wrote:
> so we still have WebPermissionTypePushNotifications value?

Renaming it will require tree-sided CL because it will break Chromium. It can be
done later.

[Miguel Garcia, 2015-04-01 18:02:04]

lgtm

[Miguel Garcia, 2015-04-01 18:02:24]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2015-04-01 18:03:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054663002/20001

[commit-bot: I haz the power, 2015-04-01 22:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-01 22:15:59]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[mlamouri (slow - plz ping), 2015-04-01 23:40:30]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-04-01 23:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from miguelg@chromium.org
Link to the patchset: https://codereview.chromium.org/1054663002/#ps40001
(title: "relax assert")

[commit-bot: I haz the power, 2015-04-01 23:41:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054663002/40001

[commit-bot: I haz the power, 2015-04-02 03:00:55]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192988