Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1054653002: Improve Mojo permission service and chrome::PermissionManager observing. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Miguel Garcia, whywhat
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve Mojo permission service and chrome::PermissionManager observing. This is fixing two bugs: - mojo callbacks were not always run, which is now required. - the service was not always unsubscribing from the PermissionManager, keeping stalled subscriptions alive. BUG=430238, 437770 Committed: https://crrev.com/a500a0fbbfbaac5ddf2f58d52be34a4d1df03f91 Cr-Commit-Position: refs/heads/master@{#323368}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -51 lines) Patch
M chrome/browser/permissions/permission_manager.cc View 2 chunks +11 lines, -1 line 0 comments Download
M content/browser/permissions/permission_service_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/permissions/permission_service_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/permissions/permission_service_impl.h View 3 chunks +35 lines, -27 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 10 chunks +51 lines, -18 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
mlamouri (slow - plz ping)
PTAL :)
5 years, 8 months ago (2015-04-01 16:56:35 UTC) #2
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-01 17:24:09 UTC) #4
whywhat
lgtm https://codereview.chromium.org/1054653002/diff/1/content/browser/permissions/permission_service_impl.cc File content/browser/permissions/permission_service_impl.cc (right): https://codereview.chromium.org/1054653002/diff/1/content/browser/permissions/permission_service_impl.cc#newcode261 content/browser/permissions/permission_service_impl.cc:261: const int* subscription_id, why const int* ??
5 years, 8 months ago (2015-04-01 18:41:17 UTC) #5
mlamouri (slow - plz ping)
On 2015/04/01 at 18:41:17, avayvod wrote: > lgtm > > https://codereview.chromium.org/1054653002/diff/1/content/browser/permissions/permission_service_impl.cc > File content/browser/permissions/permission_service_impl.cc (right): ...
5 years, 8 months ago (2015-04-01 23:25:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054653002/1
5 years, 8 months ago (2015-04-01 23:26:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 23:31:06 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 23:31:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a500a0fbbfbaac5ddf2f58d52be34a4d1df03f91
Cr-Commit-Position: refs/heads/master@{#323368}

Powered by Google App Engine
This is Rietveld 408576698