net/socket/ssl_client_socket_win.cc - Issue 10546162: NetLogEventParameter to Callback refactoring 9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_win.cc

Issue 10546162: NetLogEventParameter to Callback refactoring 9. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Update comment Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_win.cc

===================================================================

--- net/socket/ssl_client_socket_win.cc (revision 142108)

+++ net/socket/ssl_client_socket_win.cc (working copy)

@@ -568,11 +568,11 @@

DCHECK(next_state_ == STATE_NONE);

DCHECK(user_connect_callback_.is_null());

- net_log_.BeginEvent(NetLog::TYPE_SSL_CONNECT, NULL);

+ net_log_.BeginEvent(NetLog::TYPE_SSL_CONNECT);

int rv = InitializeSSLContext();

if (rv != OK) {

- net_log_.EndEvent(NetLog::TYPE_SSL_CONNECT, NULL);

+ net_log_.EndEvent(NetLog::TYPE_SSL_CONNECT);

return rv;

}

@@ -582,7 +582,7 @@

if (rv == ERR_IO_PENDING) {

user_connect_callback_ = callback;

} else {

- net_log_.EndEvent(NetLog::TYPE_SSL_CONNECT, NULL);

+ net_log_.EndEvent(NetLog::TYPE_SSL_CONNECT);

}

return rv;

}

@@ -857,7 +857,7 @@

c.Run(rv);

return;

}

- net_log_.EndEvent(NetLog::TYPE_SSL_CONNECT, NULL);

+ net_log_.EndEvent(NetLog::TYPE_SSL_CONNECT);

CompletionCallback c = user_connect_callback_;

user_connect_callback_.Reset();

c.Run(rv);