Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/client_socket_handle.cc

Issue 10546162: NetLogEventParameter to Callback refactoring 9. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Update comment Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/net.gyp ('k') | net/socket/client_socket_pool_base.cc » ('j') | net/socket/nss_ssl_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_handle.cc
===================================================================
--- net/socket/client_socket_handle.cc (revision 142108)
+++ net/socket/client_socket_handle.cc (working copy)
@@ -40,7 +40,7 @@
if (is_initialized()) {
// Because of http://crbug.com/37810 we may not have a pool, but have
// just a raw socket.
- socket_->NetLog().EndEvent(NetLog::TYPE_SOCKET_IN_USE, NULL);
+ socket_->NetLog().EndEvent(NetLog::TYPE_SOCKET_IN_USE);
if (pool_)
// If we've still got a socket, release it back to the ClientSocketPool so
// it can be deleted or reused.
@@ -147,8 +147,7 @@
DCHECK(socket_.get());
socket_->NetLog().BeginEvent(
NetLog::TYPE_SOCKET_IN_USE,
- make_scoped_refptr(new NetLogSourceParameter(
- "source_dependency", requesting_source_)));
+ requesting_source_.ToEventParametersCallback());
}
} // namespace net
« no previous file with comments | « net/net.gyp ('k') | net/socket/client_socket_pool_base.cc » ('j') | net/socket/nss_ssl_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698