Issue 10546146: MIPS: Fix failing cctest/test-api/HugeConsStringOutOfMemory test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546146: MIPS: Fix failing cctest/test-api/HugeConsStringOutOfMemory test. (Closed)

Created:
8 years, 6 months ago by palfia

Modified:
8 years, 5 months ago

Reviewers:
kisg, Paul Lind, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix failing cctest/test-api/HugeConsStringOutOfMemory test. This test is failing on MIPS since r11715 (a7d6f92c), it seems that after the modifications in bootstrapper.cc, this test runs out of old generation space on MIPS. This commit increases the old space size on MIPS arch. TEST=cctest/test-api/HugeConsStringOutOfMemory BUG=

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	test/cctest/test-api.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

Is there any reason that you can't make this change for all platforms?

8 years, 6 months ago (2012-06-14 09:56:09 UTC) #2

palfia

8 years, 6 months ago (2012-06-14 13:11:46 UTC) #3

On 2012/06/14 09:56:09, danno wrote:
> Is there any reason that you can't make this change for all platforms?

There's no particular reason, I just didn't want to change it on other
platforms, because it looks like it's a MIPS-only failure, but it can be safely
applied to all platforms and it would be a much cleaner solution.

I've uploaded another version of this CL, which enables this change to all
platform:
https://chromiumcodereview.appspot.com/10533148

Expand Messages | Collapse Messages