[net/dns] If the only name server is 0.0.0.0:53 assume DnsConfig is invalid.

[net/dns] If the only name server is 0.0.0.0:53 assume DnsConfig is invalid.

When /etc/resolv.conf has no "nameserver" entries, res_ninit will default to
a single server: 0.0.0.0:53.

BUG=130808
TEST=./net_unittests --gtest_filter=DnsConfigServicePosixTest.RejectDefaultNameserver


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142166

[szym, 2012-06-11 14:51:12]

This CL is to replace: http://codereview.chromium.org/10479005/
It changes DnsConfigService rather than just the histogram.

Note that it seems this problem affects Linux only.

[mmenke, 2012-06-11 22:38:54]

LGTM

http://codereview.chromium.org/10546081/diff/3006/net/dns/dns_config_service_...
File net/dns/dns_config_service_posix.cc (right):

http://codereview.chromium.org/10546081/diff/3006/net/dns/dns_config_service_...
net/dns/dns_config_service_posix.cc:197: return
!(dns_config->nameservers.front() == kDefaultAddress);
Wonder if it makes more sense to fail if any of the entries are 0.0.0.0:53 (Or
0.0.0.0:X), since then we presumably wouldn't be behaving the same as
getaddrinfo.

[szym, 2012-06-14 16:18:20]

http://codereview.chromium.org/10546081/diff/3006/net/dns/dns_config_service_...
File net/dns/dns_config_service_posix.cc (right):

http://codereview.chromium.org/10546081/diff/3006/net/dns/dns_config_service_...
net/dns/dns_config_service_posix.cc:197: return
!(dns_config->nameservers.front() == kDefaultAddress);
On 2012/06/11 22:38:54, Matt Menke wrote:
> Wonder if it makes more sense to fail if any of the entries are 0.0.0.0:53 (Or
> 0.0.0.0:X), since then we presumably wouldn't be behaving the same as
> getaddrinfo.

Done.

[commit-bot: I haz the power, 2012-06-14 16:18:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/szym@chromium.org/10546081/6002

[commit-bot: I haz the power, 2012-06-14 17:48:59]

Change committed as 142166