Issue 1054603002: Acknowledge that SkIcoCodec can rewind and test it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1054603002: Acknowledge that SkIcoCodec can rewind and test it. (Closed)

Created:
5 years, 8 months ago by scroggo

Modified:
5 years, 8 months ago

Reviewers:
msarett

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@bmpRewind

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Acknowledge that SkIcoCodec can rewind and test it. Since SkIcoCodec has an SkCodec for its encoded images, backed by SkMemoryStreams, the SkMemoryStream can always rewind, and will be rewound by the sub-codec if necessary (now that SkBmpCodec and SkPngCodec support rewinding). Depends on https://codereview.chromium.org/1057483003/ and https://codereview.chromium.org/1048423003/ (DIFFERENT ISSUES). BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/65a8e12287f40b1f3c3623397656f813b942b36f

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tests/CodexTest.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

scroggo

Matt, the only ICO file we have checked into resources has a sub image which ...

5 years, 8 months ago (2015-04-01 14:30:22 UTC) #2

msarett

lgtm I'll submit a CL with a new test (png-in-ico) after this lands.

5 years, 8 months ago (2015-04-01 15:57:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054603002/1

5 years, 8 months ago (2015-04-01 17:19:16 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 17:24:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/65a8e12287f40b1f3c3623397656f813b942b36f