Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: content/child/notifications/notification_data_conversions.cc

Issue 1054573002: Implement support for notification.vibrate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions.cc
diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc
index 639e55523088e68b957b92cb54fe7b9f8e00dbe7..dad89e36f666dec8bf0f78776bd51f6d88637061 100644
--- a/content/child/notifications/notification_data_conversions.cc
+++ b/content/child/notifications/notification_data_conversions.cc
@@ -24,6 +24,8 @@ PlatformNotificationData ToPlatformNotificationData(
platform_data.body = web_data.body;
platform_data.tag = base::UTF16ToUTF8(web_data.tag);
platform_data.icon = GURL(web_data.icon.string());
+ platform_data.vibrate.assign(
Peter Beverloo 2015/04/21 17:58:23 nit: please format this as follows: platform_data
Sanghyun Park 2015/04/23 11:08:26 Done.
+ web_data.vibrate.begin(), web_data.vibrate.end());
platform_data.silent = web_data.silent;
platform_data.data.assign(web_data.data.begin(), web_data.data.end());
@@ -43,6 +45,7 @@ WebNotificationData ToWebNotificationData(
web_data.body = platform_data.body;
web_data.tag = blink::WebString::fromUTF8(platform_data.tag);
web_data.icon = blink::WebURL(platform_data.icon);
+ web_data.vibrate = platform_data.vibrate;
web_data.silent = platform_data.silent;
web_data.data = platform_data.data;

Powered by Google App Engine
This is Rietveld 408576698