Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 1054573002: Implement support for notification.vibrate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_database_data.proto
diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto
index 1fb6808ba80034500a02467364acd6fcda25cf2e..149d0cd8c9103bce3c99be83f22f1a2a6b7fe85d 100644
--- a/content/browser/notifications/notification_database_data.proto
+++ b/content/browser/notifications/notification_database_data.proto
@@ -34,8 +34,9 @@ message NotificationDatabaseDataProto {
optional string body = 4;
optional string tag = 5;
optional string icon = 6;
- optional bool silent = 7;
- optional bytes data = 8;
+ repeated uint32 vibrate = 7 [packed=true];
Peter Beverloo 2015/04/21 17:58:23 uint32 should match the type you choose to use in
Sanghyun Park 2015/04/23 11:08:26 Done.
+ optional bool silent = 8;
+ optional bytes data = 9;
Avi (use Gerrit) 2015/04/21 17:28:47 I am definitely no expert in protos, but from my f
Peter Beverloo 2015/04/21 17:58:23 Indeed - please don't do this. You can insert the
Sanghyun Park 2015/04/23 11:08:26 I see, I'll use number 9.
Sanghyun Park 2015/04/23 11:08:26 I didn't know this. I'll add number for vibrate. T
}
optional NotificationData notification_data = 4;

Powered by Google App Engine
This is Rietveld 408576698