Implement support for notification.vibrate

chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.notifications;
 
 import android.app.Notification;
 import android.graphics.Bitmap;
 import android.os.Build;
 import android.test.suitebuilder.annotation.LargeTest;
 import android.test.suitebuilder.annotation.MediumTest;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.annotations.SuppressFBWarnings;
 import org.chromium.base.test.util.Feature;
 import org.chromium.base.test.util.MinAndroidSdkLevel;
 import org.chromium.chrome.browser.preferences.website.ContentSetting;
 import org.chromium.chrome.browser.preferences.website.PushNotificationInfo;
 import org.chromium.chrome.browser.widget.RoundedIconGenerator;
 import org.chromium.chrome.shell.ChromeShellTestBase;
 import org.chromium.chrome.test.util.TestHttpServerClient;
 import org.chromium.chrome.test.util.browser.notifications.MockNotificationManagerProxy;
 import org.chromium.chrome.test.util.browser.notifications.MockNotificationManagerProxy.NotificationEntry;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.content.browser.test.util.JavaScriptUtils;
 
+import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.TimeoutException;
 
 /**
  * Instrumentation tests for the Notification UI Manager implementation on Android.
  *
  * Web Notifications are only supported on Android JellyBean and beyond.
  */
 @MinAndroidSdkLevel(Build.VERSION_CODES.JELLY_BEAN)
 public class NotificationUIManagerTest extends ChromeShellTestBase {
@@ skipping 325 matching lines @@
         assertNull(NotificationUIManager.getOriginFromTag(""));
         assertNull(NotificationUIManager.getOriginFromTag(";"));
         assertNull(NotificationUIManager.getOriginFromTag(";;;;;;;"));
         assertNull(NotificationUIManager.getOriginFromTag(
                 "SystemDownloadNotifier;NotificationUIManager;42"));
         assertNull(NotificationUIManager.getOriginFromTag(
                 "SystemDownloadNotifier;https://example.com;42"));
         assertNull(NotificationUIManager.getOriginFromTag(
                 "NotificationUIManager;SystemDownloadNotifier;42"));
     }
+
+    /**
+     * Verifies that the makeDefaults method returns the generated notification defaults.
+     */
+    @SmallTest
+    @Feature({"Browser", "Notifications"})
+    public void testMakeDefaults() throws Exception {
+        // 0 should be returned if silent is true and vibration's length is 0.
+        assertEquals(0, NotificationUIManager.makeDefaults(0, true));
+
+        // Notification.DEFAULT_ALL should be returned if silent is false and
+        // vibration's length is 0.
+        assertEquals(Notification.DEFAULT_ALL,
+                NotificationUIManager.makeDefaults(0, false));
+
+        // Notification.DEFAULT_ALL & ~Notification.DEFAULT_VIBRATE should be returned
+        // if silent is false and vibration's length is greater than 0.
+        assertEquals(Notification.DEFAULT_ALL & ~Notification.DEFAULT_VIBRATE,
+                NotificationUIManager.makeDefaults(10, false));
+    }
+
+    /**
+     * Verifies that the makeVibratePattern method returns vibration pattern used
+     * in Android notification.
+     */
+    @SmallTest
+    @Feature({"Browser", "Notifications"})
+    public void testMakeVibratePattern() throws Exception {
+        assertTrue(Arrays.equals(new long[] {0, 100, 200, 300},
+                NotificationUIManager.makeVibratePattern(new int[] {100, 200, 300})));

[Peter Beverloo, 2015/05/01 17:17:59]

You should be able to do this:

import org.junit.Assert;

Assert.assertArrayEquals(...)

[Sanghyun Park, 2015/05/04 07:00:44]

Thanks for your information.
Then, as I know, junit is only used in "chrome_junit_tests" currently.
but this file is chrome_shell_test;;
For using junit, we should add junit package in chrome_shell_test_apk in
chrome_test.gypi.
Can I add this package in chrome_shell_test_apk?

[Peter Beverloo, 2015/05/05 13:11:56]

No need to do that as part of this change.

+    }
 }