Implement support for notification.vibrate

chrome/browser/notifications/platform_notification_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
@@ skipping 277 matching lines @@
   // 1x scale, whereas the displays on which they can be displayed can have a
   // different pixel density. Be smarter about this when the API gets updated
   // with a way for developers to specify images of different resolutions.
   Notification notification(origin, notification_data.title,
       notification_data.body, gfx::Image::CreateFrom1xBitmap(icon),
       display_source, notification_data.tag, delegate);
 
   notification.set_context_message(display_source);
   notification.set_silent(notification_data.silent);
 
+#if defined(OS_ANDROID)

[Peter Beverloo, 2015/04/26 23:26:41]

Sorry, I didn't mean that you had to make this Android-only, I meant that I'm
not concerned about using ~400 bytes in the very worst-case scenario per visible
Notification elsewhere.

Could you revert these changes and keep it as you had it in PS1?

[Sanghyun Park, 2015/04/27 14:00:00]

Okay I'll change to PS1.

+  // This vibrate property currently has no effect on non-Android platforms.
+  // For reducing memory, virate is not set on non-Android platforms.
+  notification.set_vibrate(notification_data.vibrate);
+#endif
+
   // Web Notifications do not timeout.
   notification.set_never_timeout(true);
 
   return notification;
 }
 
 NotificationUIManager*
 PlatformNotificationServiceImpl::GetNotificationUIManager() const {
   if (notification_ui_manager_for_tests_)
     return notification_ui_manager_for_tests_;
@@ skipping 46 matching lines @@
       formatted_origin.push_back(':');
       formatted_origin.append(base::UTF8ToUTF16(origin.port()));
     }
     return formatted_origin;
   }
 
   // TODO(dewittj): Once file:// URLs are passed in to the origin
   // GURL here, begin returning the path as the display name.
   return net::FormatUrl(origin, languages);
 }