Implement support for notification.vibrate

chrome/browser/notifications/platform_notification_service_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
@@ skipping 69 matching lines @@
     delegate->Accept();
   else
     delegate->Cancel();
 }
 
 // -----------------------------------------------------------------------------
 
 // Dimensions of the icon.png resource in the notification test data directory.
 const int kIconWidth = 100;
 const int kIconHeight = 100;
+const int kNotificationVibrate[] = { 100, 200, 300 };
 
 class PlatformNotificationServiceBrowserTest : public InProcessBrowserTest {
  public:
   PlatformNotificationServiceBrowserTest();
   ~PlatformNotificationServiceBrowserTest() override {}
 
   // InProcessBrowserTest overrides.
   void SetUp() override;
   void SetUpOnMainThread() override;
   void TearDown() override;
@@ skipping 164 matching lines @@
   EXPECT_EQ("Contents", base::UTF16ToUTF8(notification.message()));
   EXPECT_EQ("replace-id", notification.tag());
   EXPECT_FALSE(notification.icon().IsEmpty());
   EXPECT_TRUE(notification.silent());
 
   EXPECT_EQ(kIconWidth, notification.icon().Width());
   EXPECT_EQ(kIconHeight, notification.icon().Height());
 }
 
 IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
+                       WebNotificationOptionsVibrate) {
+  std::string script_result;
+
+  InfoBarResponder accepting_responder(browser(), true);
+  ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
+  EXPECT_EQ("granted", script_result);
+
+  ASSERT_TRUE(RunScript("DisplayPersistentNotificationVibrate()",
+                        &script_result));
+  EXPECT_EQ("ok", script_result);
+
+  ASSERT_EQ(1u, ui_manager()->GetNotificationCount());
+
+  const Notification& notification = ui_manager()->GetNotificationAt(0);
+  EXPECT_EQ("Title", base::UTF16ToUTF8(notification.title()));
+  EXPECT_EQ("Contents", base::UTF16ToUTF8(notification.message()));
+
+  ASSERT_EQ(arraysize(kNotificationVibrate), notification.vibrate().size());

[Peter Beverloo, 2015/04/26 23:26:41]

What do you think about renaming "vibrate" to "vibration_pattern" in Chromium,
both in the message_center::Notification object and in PlatformNotificationData?

The naming would not match the Web exposed API, but it would make reading this
code much clearer. For example, accessing the vector now looks like:

notification.vibrate()

When reading the code, I'd expect that to.. vibrate the notification, whatever
that might mean. Using "vibration" might still be slightly unclear on *what* it
is, whereas "vibration_pattern" is both clear and unambiguous.

[Sanghyun Park, 2015/04/27 14:00:00]

I like "vibration_pattern", too :)
I'll update

+  for (size_t i = 0; i < arraysize(kNotificationVibrate); ++i)
+    EXPECT_EQ(kNotificationVibrate[i], notification.vibrate()[i]);
+}
+
+IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
                        CloseDisplayedPersistentNotification) {
   std::string script_result;
 
   InfoBarResponder accepting_responder(browser(), true);
   ASSERT_TRUE(RunScript("RequestPermission()", &script_result));
   EXPECT_EQ("granted", script_result);
 
   ASSERT_TRUE(RunScript("DisplayPersistentNotification('action_close')",
       &script_result));
   EXPECT_EQ("ok", script_result);
@@ skipping 98 matching lines @@
 
   ASSERT_EQ(1u, ui_manager()->GetNotificationCount());
 
   const Notification& notification = ui_manager()->GetNotificationAt(0);
   EXPECT_FALSE(notification.icon().IsEmpty());
 
   EXPECT_EQ("Blob Title", base::UTF16ToUTF8(notification.title()));
   EXPECT_EQ(kIconWidth, notification.icon().Width());
   EXPECT_EQ(kIconHeight, notification.icon().Height());
 }