Implement support for notification.vibrate

chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.notifications;
 
 import android.app.Notification;
 import android.app.NotificationManager;
 import android.app.PendingIntent;
 import android.content.Context;
@@ skipping 285 matching lines @@
      * @param origin Full text of the origin, including the protocol, owning this notification.
      * @param tag A string identifier for this notification. If the tag is not empty, the new
      *            notification will replace the previous notification with the same tag and origin,
      *            if present. If no matching previous notification is present, the new one will just
      *            be added.
      * @param title Title to be displayed in the notification.
      * @param body Message to be displayed in the notification. Will be trimmed to one line of
      *             text by the Android notification system.
      * @param icon Icon to be displayed in the notification. When this isn't a valid Bitmap, a
      *             default icon will be generated instead.
+     * @param vibrate Vibrate pettern for notification. Pass in an array of ints that are the

[Peter Beverloo, 2015/04/21 17:58:22]

Can we keep this vague ("Vibration pattern for the Notification.") and refer to
the Android documentation for the Notification object instead?

@see http://developer.android.com/reference/android/app/Notification.html

[Sanghyun Park, 2015/04/23 11:08:25]

Okay, I'll double-check about this comment. 

+     *                durations for which to turn on or off the vibrator in milliseconds.
      * @param silent Whether the default sound, vibration and lights should be suppressed.
      */
     @CalledByNative
     private void displayNotification(long persistentNotificationId, String origin, String tag,
-            String title, String body, Bitmap icon, boolean silent) {
+            String title, String body, Bitmap icon, long[] vibrate, boolean silent) {
         if (icon == null || icon.getWidth() == 0) {
             icon = getIconGenerator().generateIconForUrl(origin, true);
         }
 
         Resources res = mAppContext.getResources();
 
         // The data used to make each intent unique according to the rules of Intent#filterEquals.
         // Without this, the pending intents derived from them may be reused, because extras are
         // not taken into account for the filterEquals comparison.
         Uri intentData = Uri.parse(origin).buildUpon().fragment(
@@ skipping 21 matching lines @@
                 .setDeleteIntent(getPendingIntent(
                         NotificationConstants.ACTION_CLOSE_NOTIFICATION,
                         persistentNotificationId, origin, tag, intentData))
                 .addAction(R.drawable.settings_cog,
                            res.getString(R.string.page_info_site_settings_button),
                            pendingSettingsIntent)
                 .setSubText(origin);
 
         // Use the system's default ringtone, vibration and indicator lights unless the notification
         // has been marked as being silent, for example because it's low priority.
-        if (!silent) notificationBuilder.setDefaults(Notification.DEFAULT_ALL);
+        // If vibrate is presented and silent set false, notification should use developer's

[Peter Beverloo, 2015/04/21 17:58:22]

We should assert for vibration to be empty here when |silent| is set to true. No
need to play nice since the only code that hits this is first-party stuff in
Chrome.

[Sanghyun Park, 2015/04/23 11:08:25]

I agree your opinion.
I'll add assert check.

+        // vibrate value.

[Peter Beverloo, 2015/04/21 17:58:22]

"If a vibration pattern is set, the notification should use the provided pattern
rather than the defaulting to system settings."

[Sanghyun Park, 2015/04/23 11:08:25]

Done.

+        if (!silent) {
+            int defaults = Notification.DEFAULT_ALL;
+            if (vibrate.length > 0) {
+                defaults &= ~Notification.DEFAULT_VIBRATE;
+                notificationBuilder.setVibrate(vibrate);
+            }
+            notificationBuilder.setDefaults(defaults);
+        }
 
         String platformTag = makePlatformTag(persistentNotificationId, origin, tag);
         mNotificationManager.notify(platformTag, PLATFORM_ID, notificationBuilder.build());
     }
 
     /**
      * Ensures the existance of an icon generator, which is created lazily.
      *
      * @return The icon generator which can be used.
      */
@@ skipping 73 matching lines @@
                                           origin, tag);
     }
 
     private static native void nativeInitializeNotificationUIManager();
 
     private native boolean nativeOnNotificationClicked(long nativeNotificationUIManagerAndroid,
             long persistentNotificationId, String origin, String tag);
     private native boolean nativeOnNotificationClosed(long nativeNotificationUIManagerAndroid,
             long persistentNotificationId, String origin, String tag);
 }