Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1054543002: Move android_app_version_* into an inner variables dict. (Closed)

Created:
5 years, 8 months ago by Tobias Sargeant
Modified:
5 years, 8 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move android_app_version_* into an inner variables dict. This is required to allow webview to provide a separately overrideable version code. BUG= Committed: https://crrev.com/81886c2785d02db150318bd7496e7493cd92db72 Cr-Commit-Position: refs/heads/master@{#323242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M android_webview/apk/java/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M build/common.gypi View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Tobias Sargeant
5 years, 8 months ago (2015-04-01 12:43:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054543002/1
5 years, 8 months ago (2015-04-01 12:49:04 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-01 12:49:08 UTC) #6
Torne
lgtm
5 years, 8 months ago (2015-04-01 13:18:06 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-01 14:50:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054543002/1
5 years, 8 months ago (2015-04-01 14:51:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 15:40:32 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 15:41:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81886c2785d02db150318bd7496e7493cd92db72
Cr-Commit-Position: refs/heads/master@{#323242}

Powered by Google App Engine
This is Rietveld 408576698