Issue 10545157: Unbreak interpreted regexp in light of recent zone related changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545157: Unbreak interpreted regexp in light of recent zone related changes. (Closed)

Created:
8 years, 6 months ago by sanjoy

Modified:
8 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Unbreak interpreted regexp in light of recent zone related changes. BUG= TEST=

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	src/jsregexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-irregexp.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-irregexp.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 6 months ago (2012-06-14 07:59:43 UTC) #2

On 2012/06/13 16:23:40, sanjoy wrote:

It still doesn't compile yet for me. The constructor in
regexp-macro-assembler-ia32.h in case of interpreted regexp still doesn't
include the zone:

In file included from src/ia32/regexp-macro-assembler-ia32.cc:37:
src/ia32/regexp-macro-assembler-ia32.h: In constructor
'v8::internal::RegExpMacroAssemblerIA32::RegExpMacroAssemblerIA32()':
src/ia32/regexp-macro-assembler-ia32.h:40: error: no matching function for call
to 'v8::internal::RegExpMacroAssembler::RegExpMacroAssembler()'
src/regexp-macro-assembler.h:66: note: candidates are:
v8::internal::RegExpMacroAssembler::RegExpMacroAssembler(v8::internal::Zone*)
src/regexp-macro-assembler.h:42: note:                
v8::internal::RegExpMacroAssembler::RegExpMacroAssembler(const
v8::internal::RegExpMacroAssembler&)

Expand Messages | Collapse Messages