Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1054503003: Adjust CSS in DOM Distiller for different color themes (Closed)

Created:
5 years, 8 months ago by wychen
Modified:
5 years, 8 months ago
Reviewers:
mdjones, cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust CSS in DOM Distiller for different color themes Tags "q" and "cite" were invisible in dark theme. BUG=480646 Committed: https://crrev.com/f52f3ff9c8654a8181cb97ed05ed393961854efc Cr-Commit-Position: refs/heads/master@{#326920}

Patch Set 1 #

Patch Set 2 : fix feedback size #

Total comments: 2

Patch Set 3 : address mdjones' feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M components/dom_distiller/core/css/distilledpage.css View 1 2 7 chunks +27 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
wychen
PTAL
5 years, 8 months ago (2015-04-20 20:58:20 UTC) #2
mdjones
https://codereview.chromium.org/1054503003/diff/20001/components/dom_distiller/core/css/distilledpage.css File components/dom_distiller/core/css/distilledpage.css (right): https://codereview.chromium.org/1054503003/diff/20001/components/dom_distiller/core/css/distilledpage.css#newcode252 components/dom_distiller/core/css/distilledpage.css:252: font-size: 1.5rem; /* why larger ?? */ I don't ...
5 years, 8 months ago (2015-04-21 23:11:04 UTC) #3
wychen
https://codereview.chromium.org/1054503003/diff/20001/components/dom_distiller/core/css/distilledpage.css File components/dom_distiller/core/css/distilledpage.css (right): https://codereview.chromium.org/1054503003/diff/20001/components/dom_distiller/core/css/distilledpage.css#newcode252 components/dom_distiller/core/css/distilledpage.css:252: font-size: 1.5rem; /* why larger ?? */ On 2015/04/21 ...
5 years, 8 months ago (2015-04-22 00:07:45 UTC) #4
mdjones
My only other concern is possibly having some sort of standard color palette to use; ...
5 years, 8 months ago (2015-04-24 16:33:52 UTC) #5
cjhopman
lgtm
5 years, 8 months ago (2015-04-24 18:58:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054503003/40001
5 years, 8 months ago (2015-04-24 21:57:11 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 22:58:11 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 23:00:16 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f52f3ff9c8654a8181cb97ed05ed393961854efc
Cr-Commit-Position: refs/heads/master@{#326920}

Powered by Google App Engine
This is Rietveld 408576698