Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: Source/bindings/templates/union.h

Issue 1054443002: Make classes for union types exported. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/union.h
diff --git a/Source/bindings/templates/union.h b/Source/bindings/templates/union.h
index 2c1f644475b779b58c8d9398cd6daec7ef8f06ba..2d53048c635aaf16af9a57a6083b98af4e8d6e85 100644
--- a/Source/bindings/templates/union.h
+++ b/Source/bindings/templates/union.h
@@ -18,7 +18,7 @@ class {{decl}};
{% endfor %}
{% for container in containers %}
-class {{container.cpp_class}} final {
+class {{exported}}{{container.cpp_class}} final {
ALLOW_ONLY_INLINE_ALLOCATION();
public:
{{container.cpp_class}}();
@@ -31,6 +31,11 @@ public:
static {{container.cpp_class}} from{{member.type_name}}({{member.rvalue_cpp_type}});
{% endfor %}
+#if COMPILER(MSVC) && defined(COMPONENT_BUILD) && LINK_CORE_MODULES_SEPARATELY
haraken 2015/04/01 07:03:13 Add a comment on this.
tasak 2015/04/02 05:31:37 Done.
+ {{container.cpp_class}}(const {{container.cpp_class}}&);
+ ~{{container.cpp_class}}();
+ {{container.cpp_class}}& operator=(const {{container.cpp_class}}&);
+#endif
{% if container.needs_trace %}
DECLARE_TRACE();
@@ -48,15 +53,15 @@ private:
{{member.cpp_type}} m_{{member.cpp_name}};
{% endfor %}
- friend v8::Local<v8::Value> toV8(const {{container.cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
+ friend {{exported}}v8::Local<v8::Value> toV8(const {{container.cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
};
class V8{{container.cpp_class}} final {
public:
- static void toImpl(v8::Isolate*, v8::Local<v8::Value>, {{container.cpp_class}}&, ExceptionState&);
+ {{exported}}static void toImpl(v8::Isolate*, v8::Local<v8::Value>, {{container.cpp_class}}&, ExceptionState&);
};
-v8::Local<v8::Value> toV8(const {{container.cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
+{{exported}}v8::Local<v8::Value> toV8(const {{container.cpp_class}}&, v8::Local<v8::Object>, v8::Isolate*);
template <class CallbackInfo>
inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{container.cpp_class}}& impl)

Powered by Google App Engine
This is Rietveld 408576698