Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1054433004: safe_browsing: Simplify code in ReadData() by calling base::MD5String(). (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

safe_browsing: Simplify code in ReadData() by calling base::MD5String(). base's MD5String() is a helper function that does exactly what this piece of code in ReadData() is doing, so we can just call MD5String() and simplify it instead. BUG=None R=mattm@chromium.org Committed: https://crrev.com/bd58f1007a35d83ca8e5441d744795b7c14410e6 Cr-Commit-Position: refs/heads/master@{#323998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/safe_browsing/malware_details_cache.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL
5 years, 8 months ago (2015-04-06 22:57:43 UTC) #1
mattm
lgtm
5 years, 8 months ago (2015-04-07 00:57:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054433004/1
5 years, 8 months ago (2015-04-07 00:57:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 01:23:45 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 01:24:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd58f1007a35d83ca8e5441d744795b7c14410e6
Cr-Commit-Position: refs/heads/master@{#323998}

Powered by Google App Engine
This is Rietveld 408576698