Fix Red/Blue decoding problem in WebP.

Fix Red/Blue decoding problem in WebP.

Added unit test with lossless webp data.

BUG=skia:1402
Will need to rebaseline webp expectations for some systems.

R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12803

[scroggo, 2013-12-11 19:59:04]

nit: From the description, BUG=Skia:1402 does not get turned into a link, but
BUG=skia:1402 does (should probably fix that elsewhere).

The code change looks good. As mentioned in the test, I think that should be
covered by our image decoding tests, which you'll need to update.

lgtm

https://codereview.chromium.org/105443005/diff/1/tests/ImageDecodingTest.cpp
File tests/ImageDecodingTest.cpp (right):

https://codereview.chromium.org/105443005/diff/1/tests/ImageDecodingTest.cpp#...
tests/ImageDecodingTest.cpp:305: const SkColor* correctPixel = thePixels;
The test looks fine, although we run other tests specific to image decoding,
which include testing webp files. In fact you'll need to update the expectations
for those files to match the new version.

[scroggo, 2013-12-17 23:12:26]

On 2013/12/11 19:59:04, scroggo wrote:
> nit: From the description, BUG=Skia:1402 does not get turned into a link, but
> BUG=skia:1402 does (should probably fix that elsewhere).
> 
> The code change looks good. As mentioned in the test, I think that should be
> covered by our image decoding tests, which you'll need to update.
> 
> lgtm
> 
> https://codereview.chromium.org/105443005/diff/1/tests/ImageDecodingTest.cpp
> File tests/ImageDecodingTest.cpp (right):
> 
>
https://codereview.chromium.org/105443005/diff/1/tests/ImageDecodingTest.cpp#...
> tests/ImageDecodingTest.cpp:305: const SkColor* correctPixel = thePixels;
> The test looks fine, although we run other tests specific to image decoding,
> which include testing webp files. In fact you'll need to update the
expectations
> for those files to match the new version.

Once you check this in, you ought to be able to update the expectations (after
one round of the bots failing) by running

./tools/rebaseline.py --skimage

from your Skia tree. We don't currently have an easy way to verify the new
expectations, but a good guess will be if only Windows and Linux bots change.

[hal.canary, 2013-12-20 16:35:27]

Committed patchset #2 manually as r12803 (presubmit successful).