Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1054423002: Replace layout with updateLayout during dumping LayoutTree (Closed)

Created:
5 years, 8 months ago by qiankun
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace layout with updateLayout during dumping LayoutTree BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193144

Patch Set 1 #

Patch Set 2 : use root->document().updateLayout() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/layout/LayoutTreeAsText.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qiankun
This CL is driven by https://codereview.chromium.org/999033002/#msg24. For fast/css/resize-corner-tracking.html, it would trigger a layout when doing ...
5 years, 8 months ago (2015-04-03 16:30:07 UTC) #2
esprehn
You want to do view->document()->updateLayout(). The previous unconditional call also updated style, which may mark ...
5 years, 8 months ago (2015-04-03 16:45:19 UTC) #3
qiankun
On 2015/04/03 16:45:19, esprehn wrote: > You want to do view->document()->updateLayout(). > > The previous ...
5 years, 8 months ago (2015-04-03 17:12:16 UTC) #4
leviw_travelin_and_unemployed
lgtm.
5 years, 8 months ago (2015-04-03 18:27:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054423002/20001
5 years, 8 months ago (2015-04-03 18:27:45 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:11:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193144

Powered by Google App Engine
This is Rietveld 408576698