Remove the "alternate_url" outparam from

Remove the "alternate_url" outparam from

  HttpStreamFactoryImpl::GetAlternativeServiceRequestFor().

Remove the "original_url" param from

  HttpStreamFactoryImpl::Job::MarkAsAlternate()

Remove the original_url_ member from HttpStreamFactoryImpl::Job
and instead change origin_url_ to always be the actual URL to
request. Add a new alternative_service_url_ to store the "modified"
URL which is to be used for consulting socket pools and resolving
proxies.

Committed: https://crrev.com/32fde13971e4af00a608bc0286331a5d9b2f1213
Cr-Commit-Position: refs/heads/master@{#323852}

[Ryan Hamilton, 2015-04-03 16:15:54]

rch@chromium.org changed reviewers:
+ bnc@chromium.org

[Bence, 2015-04-03 19:35:52]

LGTM % nits.

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl.cc:11: #include
"base/strings/string_number_conversions.h"
Is this include still needed?

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl.cc:200: } else {
Maybe do an early |return alternative_service;| here and outdent the rest of
this method?

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl_job.h (right):

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl_job.h:278: // |alternate_service_| and
"https://" scheme.
Please clarify that for a non-alternate Job, this is the same as origin_url_.

[Ryan Hamilton, 2015-04-03 20:33:22]

Thanks!

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl.cc (right):

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl.cc:11: #include
"base/strings/string_number_conversions.h"
On 2015/04/03 19:35:52, Bence wrote:
> Is this include still needed?

Done.

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl.cc:200: } else {
On 2015/04/03 19:35:52, Bence wrote:
> Maybe do an early |return alternative_service;| here and outdent the rest of
> this method?

Done.

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
File net/http/http_stream_factory_impl_job.h (right):

https://codereview.chromium.org/1054413002/diff/40001/net/http/http_stream_fa...
net/http/http_stream_factory_impl_job.h:278: // |alternate_service_| and
"https://" scheme.
On 2015/04/03 19:35:52, Bence wrote:
> Please clarify that for a non-alternate Job, this is the same as origin_url_.

Done.

[Ryan Hamilton, 2015-04-03 20:33:31]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-04-03 20:33:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1054413002/#ps60001
(title: "fix comments")

[commit-bot: I haz the power, 2015-04-03 20:33:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054413002/60001

[commit-bot: I haz the power, 2015-04-03 21:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 21:39:24]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Ryan Hamilton, 2015-04-03 23:01:41]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-04-03 23:01:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/1054413002/#ps80001
(title: "Fix preconnect")

[commit-bot: I haz the power, 2015-04-03 23:02:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054413002/80001

[commit-bot: I haz the power, 2015-04-03 23:51:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-03 23:52:02]

Patchset 5 (id:??) landed as
https://crrev.com/32fde13971e4af00a608bc0286331a5d9b2f1213
Cr-Commit-Position: refs/heads/master@{#323852}