Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

Issue 1054363002: Update DataReductionProxyNetworkDelegate/BypassStats to post tasks safely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bengr CR comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
index 08457ba84f1ba36bb88a0aa8d3bf9dba71049ef5..8cb016eb79b9ce37cf34570688e0f9b661b45be2 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
@@ -7,9 +7,7 @@
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
-#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "base/memory/weak_ptr.h"
#include "base/values.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h"
#include "net/base/layered_network_delegate.h"
@@ -22,10 +20,6 @@ typedef PrefMember<bool> BooleanPrefMember;
class GURL;
class PrefService;
-namespace base {
-class SingleThreadTaskRunner;
-}
-
namespace net {
class HttpResponseHeaders;
class HttpRequestHeaders;
@@ -39,11 +33,11 @@ class URLRequest;
namespace data_reduction_proxy {
+class DataReductionProxyBypassStats;
class DataReductionProxyConfig;
class DataReductionProxyConfigurator;
class DataReductionProxyIOData;
class DataReductionProxyRequestOptions;
-class DataReductionProxyBypassStats;
// DataReductionProxyNetworkDelegate is a LayeredNetworkDelegate that wraps a
// NetworkDelegate and adds Data Reduction Proxy specific logic.
@@ -69,7 +63,6 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {
// Initializes member variables to record data reduction proxy prefs and
// report UMA.
void InitIODataAndUMA(
- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
DataReductionProxyIOData* io_data,
BooleanPrefMember* data_reduction_proxy_enabled,
DataReductionProxyBypassStats* bypass_stats);
@@ -117,15 +110,6 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {
int64 original_content_length,
DataReductionProxyRequestType request_type);
- // Records daily data savings statistics to prefs and reports data savings
- // UMA.
- void UpdateContentLengthPrefs(int received_content_length,
- int original_content_length,
- bool data_reduction_proxy_enabled,
- DataReductionProxyRequestType request_type);
-
- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
-
// Total size of all content (excluding headers) that has been received
// over the network.
int64 received_content_length_;

Powered by Google App Engine
This is Rietveld 408576698