components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc - Issue 1054363002: Update DataReductionProxyNetworkDelegate/BypassStats to post tasks safely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

Issue 1054363002: Update DataReductionProxyNetworkDelegate/BypassStats to post tasks safely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bengr CR comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

index f0438b0db0101c325b58a6d5fdc22453c9621533..c9c92e10352b0758259b5eef56dd7abd77fd60be 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc

@@ -114,7 +114,7 @@ TEST_F(DataReductionProxyIODataTest, TestConstruction) {

base::Bind(&DataReductionProxyIODataTest::RequestCallback,

base::Unretained(this)), nullptr);

EXPECT_EQ(1, wrapped_network_delegate->created_requests());

- EXPECT_EQ(nullptr, io_data->bypass_stats());

+ EXPECT_NE(nullptr, io_data->bypass_stats());

// Creating a second delegate with bypass statistics tracking should result

// in usage stats being created.