lib/src/checker/checker.dart - Issue 1054343004: Update to use the latest analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/checker/checker.dart

Issue 1054343004: Update to use the latest analyzer (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/checker/checker.dart

diff --git a/lib/src/checker/checker.dart b/lib/src/checker/checker.dart

index 58d18f0e753c8306c15de20629bfe81ed3b0df07..1496dd857c782b15354796452e6a618e661a8e4c 100644

--- a/lib/src/checker/checker.dart

+++ b/lib/src/checker/checker.dart

@@ -472,7 +472,7 @@ class CodeChecker extends RecursiveAstVisitor {

int len = list.length;

for (int i = 0; i < len; ++i) {

Expression arg = list[i];

- ParameterElement element = node.getStaticParameterElementFor(arg);

+ ParameterElement element = arg.propagatedParameterElement;

vsm 2015/04/07 17:55:09 We haven't been using the propagated types / eleme

Siggi Cherem (dart-lang) 2015/04/07 18:06:44 Good catch - I was just changing this based on the

if (element == null) {

if (type.parameters.length < len) {

// We found an argument mismatch, the analyzer will report this too,

« no previous file with comments | « lib/runtime/dart/collection.js ('k') | lib/src/checker/resolver.dart » ('j') | no next file with comments »