Update to use the latest analyzer

Update to use the latest analyzer

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/f951401355c61f5d281a513beb354e191e350012

[Siggi Cherem (dart-lang), 2015-04-07 17:42:16]

sigmund@google.com changed reviewers:
+ jmesserly@google.com

[Siggi Cherem (dart-lang), 2015-04-07 17:42:16]

I'm not sure why I'm seeing the changes in the SDK as a result of this though.
Any clues?

[vsm, 2015-04-07 17:55:09]

vsm@google.com changed reviewers:
+ vsm@google.com

[vsm, 2015-04-07 17:55:09]

https://codereview.chromium.org/1054343004/diff/1/lib/src/checker/checker.dart
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/1054343004/diff/1/lib/src/checker/checker.dar...
lib/src/checker/checker.dart:475: ParameterElement element =
arg.propagatedParameterElement;
We haven't been using the propagated types / elements for the most part.  Is it
really safe here?

[Siggi Cherem (dart-lang), 2015-04-07 18:06:44]

https://codereview.chromium.org/1054343004/diff/1/lib/src/checker/checker.dart
File lib/src/checker/checker.dart (right):

https://codereview.chromium.org/1054343004/diff/1/lib/src/checker/checker.dar...
lib/src/checker/checker.dart:475: ParameterElement element =
arg.propagatedParameterElement;
On 2015/04/07 17:55:09, vsm wrote:
> We haven't been using the propagated types / elements for the most part.  Is
it
> really safe here?

Good catch - I was just changing this based on the deprecation message here:
https://github.com/dart-lang/ddc_analyzer/blob/master/lib/src/generated/ast.d...

seems like a copy/paste error and that they meant to point us to
`staticParameterElement` instead.

Fixed

[Jennifer Messerly, 2015-04-08 20:21:26]

https://codereview.chromium.org/1054343004/diff/20001/lib/runtime/dart/_inter...
File lib/runtime/dart/_internal.js (right):

https://codereview.chromium.org/1054343004/diff/20001/lib/runtime/dart/_inter...
lib/runtime/dart/_internal.js:203: result = new (core.List$(E))();
FYI: this is a bug fix. Analyzer used to think all variables in methods were
mutated in closures, regardless of whether any closures actually existed :) 
(they were missing visitMethodDeclaration, so it thought the result= assignment
in the else branch was in a closure when it compared against the
_enclosingFunction, which was incorrectly `null`)

[Jennifer Messerly, 2015-04-08 20:22:08]

also, LGTM!

[Siggi Cherem (dart-lang), 2015-04-08 20:47:32]

Committed patchset #2 (id:20001) manually as
f951401355c61f5d281a513beb354e191e350012 (presubmit successful).