Clean up URLFetcher unit tests, part 1

Clean up URLFetcher unit tests, part 1

Move test server into test fixture, remove dependencies on
url_request_unittest files.

BUG=471069
Committed: https://crrev.com/157fb6c973dc7d8754f323c08dc668c2c19eba08
Cr-Commit-Position: refs/heads/master@{#323811}

[mmenke, 2015-04-03 16:50:43]

mmenke@chromium.org changed reviewers:
+ davidben@chromium.org

[mmenke, 2015-04-03 16:50:44]

This test fixture is sufficiently ugly that I feel I should clean it up before
adding more cruft.  After this CL, I plan on doing two more things (Probably in
more a lot more than 2 CLs):

1)  Unify URLRequestContexts/ContextGetters between all tests (There are
currently 3 sets with meaningful differences across the tests, I believe).

2)  Instead of having all the EXPECTs in the each test fixture's callback,
create a shared URLFetcherDelegate class, have it gather information in its
callback, and put the EXPECTs in the actual test bodies.  This will require a
lot of changed code, but should be fairly straightforward for most tests.  Those
that need special handling can use their own URLFetcherDelegate class.

I may get bored before I get everything done, but I'd like to leave the tests in
a more reasonable state.

[davidben, 2015-04-03 20:18:20]

lgtm

https://codereview.chromium.org/1054343003/diff/30001/net/url_request/url_fet...
File net/url_request/url_fetcher_impl_unittest.cc (right):

https://codereview.chromium.org/1054343003/diff/30001/net/url_request/url_fet...
net/url_request/url_fetcher_impl_unittest.cc:90: fetcher_(NULL),
Nit: While you're here, switch this to nullptr?

https://codereview.chromium.org/1054343003/diff/30001/net/url_request/url_fet...
net/url_request/url_fetcher_impl_unittest.cc:137: // Initializes |test_server_|
withotu starting it.  Allows subclasses to use
withotu -> without

[mmenke, 2015-04-03 20:20:51]

Thanks!

https://codereview.chromium.org/1054343003/diff/30001/net/url_request/url_fet...
File net/url_request/url_fetcher_impl_unittest.cc (right):

https://codereview.chromium.org/1054343003/diff/30001/net/url_request/url_fet...
net/url_request/url_fetcher_impl_unittest.cc:90: fetcher_(NULL),
On 2015/04/03 20:18:20, David Benjamin wrote:
> Nit: While you're here, switch this to nullptr?

Done.

https://codereview.chromium.org/1054343003/diff/30001/net/url_request/url_fet...
net/url_request/url_fetcher_impl_unittest.cc:137: // Initializes |test_server_|
withotu starting it.  Allows subclasses to use
On 2015/04/03 20:18:20, David Benjamin wrote:
> withotu -> without

Done.

[mmenke, 2015-04-03 20:21:00]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-04-03 20:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1054343003/#ps50001
(title: "Response to comments")

[commit-bot: I haz the power, 2015-04-03 20:21:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054343003/50001

[commit-bot: I haz the power, 2015-04-03 20:48:14]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2015-04-03 20:49:09]

Patchset 4 (id:??) landed as
https://crrev.com/157fb6c973dc7d8754f323c08dc668c2c19eba08
Cr-Commit-Position: refs/heads/master@{#323811}