Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 105433002: Cleanup: Rename NumberOfAlgorithmOperations --> LastAlgorithmOperation. (Closed)

Created:
7 years ago by eroman
Modified:
7 years ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Cleanup: Rename NumberOfAlgorithmOperations --> LastAlgorithmOperation. This avoids having to handle the sentinel enum value inside of switch statements. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163304

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/modules/crypto/Key.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eroman
7 years ago (2013-12-04 20:09:38 UTC) #1
abarth-chromium
lgtm
7 years ago (2013-12-05 04:23:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/105433002/20001
7 years ago (2013-12-05 04:23:58 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/modules/crypto/NormalizeAlgorithm.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-05 04:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/105433002/40001
7 years ago (2013-12-05 18:48:34 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=19697
7 years ago (2013-12-05 21:38:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/105433002/40001
7 years ago (2013-12-06 02:35:18 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-06 06:56:46 UTC) #8
Message was sent while issue was closed.
Change committed as 163304

Powered by Google App Engine
This is Rietveld 408576698