gpu: Add support for GLX_EXT_texture_from_pixmap extension.

content/common/gpu/gpu_channel_manager.h

Index: content/common/gpu/gpu_channel_manager.h
diff --git a/content/common/gpu/gpu_channel_manager.h b/content/common/gpu/gpu_channel_manager.h
index b256a56d8d0123b600f2f1140fefddf1ade58975..c1d85cf206cd08ad01f1dd782605799e94807e34 100644
--- a/content/common/gpu/gpu_channel_manager.h
+++ b/content/common/gpu/gpu_channel_manager.h
@@ -5,6 +5,7 @@
 #ifndef CONTENT_COMMON_GPU_GPU_CHANNEL_MANAGER_H_
 #define CONTENT_COMMON_GPU_GPU_CHANNEL_MANAGER_H_
 
+#include <deque>
 #include <vector>
 
 #include "base/hash_tables.h"
@@ -96,6 +97,8 @@ class GpuChannelManager : public IPC::Listener,
   gfx::GLSurface* GetDefaultOffscreenSurface();
 
  private:
+  typedef std::pair<int32, base::Closure> ImageOperation;

[piman, 2012/10/17 17:46:20]

nit: we usually avoid std::pair except for implicit types. Rather, a simple
struct (with a trivial constructor if it's useful) is usually better because it
gives proper names to the fields. For example, here, it's very difficult to know
if the first parameter represents an image ID, a client ID or a sync point.
Where it gets used, we have to mentally translate "first" and "second" into
whichever field this is meant to be.

+
   // Message handlers.
   void OnEstablishChannel(int client_id, bool share_context);
   void OnCloseChannel(const IPC::ChannelHandle& channel_handle);
@@ -106,6 +109,13 @@ class GpuChannelManager : public IPC::Listener,
       int32 render_view_id,
       int32 client_id,
       const GPUCreateCommandBufferConfig& init_params);
+  void CreateImage(
+      gfx::PluginWindowHandle window, int32 client_id, int32 image_id);
+  void OnCreateImage(
+      gfx::PluginWindowHandle window, int32 client_id, int32 image_id);
+  void DeleteImage(int32 client_id, int32 image_id);
+  void OnDeleteImage(int32 client_id, int32 image_id, int32 sync_point);
+  void OnDeleteImageSyncPointRetired(ImageOperation*);
 
   void OnLoseAllContexts();
 
@@ -127,6 +137,8 @@ class GpuChannelManager : public IPC::Listener,
   scoped_refptr<SyncPointManager> sync_point_manager_;
   scoped_ptr<gpu::gles2::ProgramCache> program_cache_;
   scoped_refptr<gfx::GLSurface> default_offscreen_surface_;
+  typedef std::deque<ImageOperation> ImageOperationQueue;

[piman, 2012/10/17 17:46:20]

nit: typedefs usually go together at the top of the "private" section.
(agreed this file isn't very consistent with this)

+  ImageOperationQueue image_operations_;
 
   DISALLOW_COPY_AND_ASSIGN(GpuChannelManager);
 };