gpu: Add support for GLX_EXT_texture_from_pixmap extension.

gpu/command_buffer/service/image_manager.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_
+#define GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_
+
+#include "base/basictypes.h"
+#include "base/hash_tables.h"
+#include "base/memory/ref_counted.h"
+#include "gpu/gpu_export.h"
+
+namespace gfx {
+class GLImage;
+}
+
+namespace gpu {
+namespace gles2 {
+
+// Interface used by the cmd decoder to lookup images.
+class GPU_EXPORT ImageManager : public base::RefCounted<ImageManager> {
+ public:
+  ImageManager();
+
+  void AddImage(scoped_refptr<gfx::GLImage> gl_image, int32 service_id);

[greggman, 2012/10/17 18:32:16]

Is there some reason to pass around scoped_refptrs? I thought generally we
passed raw pointers around since scoped_refptrs can be made from raw pointers
and because passing them around means lots of extra ref count manipulation.

[reveman, 2012/10/17 21:22:55]

You can have an image bound to multiple textures and deleting an image doesn't
affect current bindings. The image instance is deleted when the image_id is gone
and no texture bindings exist:

tex1 = context->createTexture();
CreateImage(XID, img1, callback1);

callback1() {
context->bindTexture(tex1);
context->bindTexImage2DCHROMIUM(img1);
DeleteImage(img1, context->insertSyncPoint());
context->drawArrays(..); // Draw image img1
}

+  void RemoveImage(int32 service_id);
+  scoped_refptr<gfx::GLImage> LookupImage(int32 service_id);
+
+ private:
+  friend class base::RefCounted<ImageManager>;
+
+  ~ImageManager();
+
+  typedef base::hash_map<uint32, scoped_refptr<gfx::GLImage> > GLImageMap;
+  GLImageMap gl_images_;
+
+  DISALLOW_COPY_AND_ASSIGN(ImageManager);
+};
+
+}  // namespage gles2
+}  // namespace gpu
+
+#endif  // GPU_COMMAND_BUFFER_SERVICE_IMAGE_MANAGER_H_