Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1054303004: Sync CSS interfaces with the specs (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 8 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, arv+blink, blink-reviews-style_chromium.org, vivekg_samsung, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, vivekg, dglazkov+blink, blink-reviews-events_chromium.org, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync CSS interfaces with the specs Other than code movement, there are two changes to the generated code: CSSImportRule.href and StyleSheet.type are made non-nullable, so v8SetReturnValueString is used instead of v8SetReturnValueStringOrNull. This doesn't matter, because these never return String() internally. If they did, the return value would change from null to the empty string. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -90 lines) Patch
M Source/core/css/CSS.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontFaceRule.idl View 1 chunk +8 lines, -2 lines 0 comments Download
M Source/core/css/CSSImportRule.idl View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/css/CSSKeyframeRule.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.idl View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/core/css/CSSMediaRule.idl View 1 chunk +7 lines, -4 lines 0 comments Download
M Source/core/css/CSSPageRule.idl View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/css/CSSRule.idl View 2 chunks +22 lines, -10 lines 0 comments Download
M Source/core/css/CSSRuleList.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +22 lines, -14 lines 0 comments Download
M Source/core/css/CSSStyleRule.idl View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/css/CSSStyleSheet.idl View 1 chunk +8 lines, -10 lines 0 comments Download
M Source/core/css/CSSSupportsRule.idl View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/css/CSSUnknownRule.idl View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/core/css/CSSViewportRule.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/MediaList.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/css/MediaQueryList.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryListEvent.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StyleMedia.idl View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/css/StyleSheet.idl View 1 chunk +11 lines, -9 lines 0 comments Download
M Source/core/css/StyleSheetList.idl View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 8 months ago (2015-04-03 08:30:04 UTC) #2
Timothy Loh
lgtm
5 years, 8 months ago (2015-04-08 00:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054303004/1
5 years, 8 months ago (2015-04-08 11:41:38 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 13:21:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193357

Powered by Google App Engine
This is Rietveld 408576698