[Webapp Refactor] Implements remoting.Activity.

remoting/webapp/crd/js/desktop_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to desktop
  * remoting ("Chromoting" or CRD).
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * @param {Array<string>} appCapabilities Array of application capabilities.
  * @constructor
  * @implements {remoting.ApplicationInterface}
  * @extends {remoting.Application}
  */
 remoting.DesktopRemoting = function(appCapabilities) {
   base.inherits(this, remoting.Application, appCapabilities);
 
-  /**
-   * Whether to refresh the JID and retry the connection if the current JID
-   * is offline.
-   *
-   * @private {boolean}
-   */
-  this.refreshHostJidIfOffline_ = true;
+  /** @private {remoting.DesktopConnectedView} */
+  this.connectedView_ = null;
 
-  /** @private {remoting.DesktopConnectedView} */
+  /** @private {remoting.ConnectFlow} */
+  this.flow_ = null;
+};
+
+/** @private */
+remoting.DesktopRemoting.prototype.reset_ = function() {
+  base.dispose(this.connectedView_);
   this.connectedView_ = null;

[Jamie, 2015/04/03 19:54:23]

Dispose of flow_ as well?

[kelvinp, 2015/04/06 23:01:39]

The Me2MeActivity triggers a reconnect underneath the hood on connection failed,
but it won't re-notify the DesktopRemoting upon successful re-connection.
If we dispose the flow here, the flow won't be recreated.
The underlying problem will go away once we make the Activity (previously known
as flow) to own the client session. 

 };
 
 /**
  * @return {string} Application product name to be used in UI.
  * @override {remoting.ApplicationInterface}
  */
 remoting.DesktopRemoting.prototype.getApplicationName = function() {
   return chrome.i18n.getMessage(/*i18n-content*/'PRODUCT_NAME');
 };
 
@@ skipping 100 matching lines @@
   this.closeMainWindow_();
 };
 
 /**
  * @param {remoting.ConnectionInfo} connectionInfo
  * @override {remoting.ApplicationInterface}
  */
 remoting.DesktopRemoting.prototype.onConnected_ = function(connectionInfo) {
   this.initSession_(connectionInfo);
 
-  // Set the text on the buttons shown under the error message so that they are
-  // easy to understand in the case where a successful connection failed, as
-  // opposed to the case where a connection never succeeded.
-  // TODO(garykac): Investigate to see if these need to be reverted to their
-  // original values in the onDisconnected_ method.
-  var button1 = document.getElementById('client-reconnect-button');

[kelvinp, 2015/04/02 23:28:10]

This code is removed altogether as we always change the label to RECONNECT upon
a successful connection, and we never show this UI if the connection failed.

-  l10n.localizeElementFromTag(button1, /*i18n-content*/'RECONNECT');
-  button1.removeAttribute('autofocus');
-  var button2 = document.getElementById('client-finished-me2me-button');
-  l10n.localizeElementFromTag(button2, /*i18n-content*/'OK');
-  button2.setAttribute('autofocus', 'autofocus');
-
-  // Reset the refresh flag so that the next connection will retry if needed.
-  this.refreshHostJidIfOffline_ = true;

[kelvinp, 2015/04/02 23:28:10]

Moved to Me2MeConnectFlow.onConnected();

-
-  document.getElementById('access-code-entry').value = '';

[kelvinp, 2015/04/02 23:28:10]

Moved to It2MeConnectFlow.onConnected();

   remoting.setMode(remoting.AppMode.IN_SESSION);
   if (!base.isAppsV2()) {
     remoting.toolbar.center();
     remoting.toolbar.preview();
   }
 
   this.connectedView_ = new remoting.DesktopConnectedView(
       document.getElementById('client-container'), connectionInfo);
 
   // By default, under ChromeOS, remap the right Control key to the right
   // Win / Cmd key.
   if (remoting.platformIsChromeOS()) {
     connectionInfo.plugin().setRemapKeys('0x0700e4>0x0700e7');
   }
 
-  if (remoting.app.getConnectionMode() === remoting.Application.Mode.ME2ME) {

[kelvinp, 2015/04/02 23:28:10]

Moved to Me2MeConnectFlow.onConnected();

-    if (remoting.app.hasCapability(remoting.ClientSession.Capability.CAST)) {
-      this.sessionConnector_.registerProtocolExtension(
-          new remoting.CastExtensionHandler());
-    }
-    this.sessionConnector_.registerProtocolExtension(
-        new remoting.GnubbyAuthHandler());
-  }
   if (connectionInfo.session().hasCapability(
           remoting.ClientSession.Capability.VIDEO_RECORDER)) {
     var recorder = new remoting.VideoFrameRecorder();
     this.sessionConnector_.registerProtocolExtension(recorder);
     this.connectedView_.setVideoFrameRecorder(recorder);
   }
 
-  if (remoting.pairingRequested) {

[kelvinp, 2015/04/02 23:28:10]

Moved to PinDialog.requestPairingIfNecessary();

-    var that = this;
-    /**
-     * @param {string} clientId
-     * @param {string} sharedSecret
-     */
-    var onPairingComplete = function(clientId, sharedSecret) {
-      var connector = that.sessionConnector_;
-      var host = remoting.hostList.getHostForId(connector.getHostId());
-      host.options.pairingInfo.clientId = clientId;
-      host.options.pairingInfo.sharedSecret = sharedSecret;
-      host.options.save();
-      connector.updatePairingInfo(clientId, sharedSecret);
-    };
-    // Use the platform name as a proxy for the local computer name.
-    // TODO(jamiewalch): Use a descriptive name for the local computer, for
-    // example, its Chrome Sync name.
-    var clientName = '';
-    if (remoting.platformIsMac()) {
-      clientName = 'Mac';
-    } else if (remoting.platformIsWindows()) {
-      clientName = 'Windows';
-    } else if (remoting.platformIsChromeOS()) {
-      clientName = 'ChromeOS';
-    } else if (remoting.platformIsLinux()) {
-      clientName = 'Linux';
-    } else {
-      console.log('Unrecognized client platform. Using navigator.platform.');
-      clientName = navigator.platform;
-    }
-    connectionInfo.session().requestPairing(clientName, onPairingComplete);
-  }
+  this.flow_.onConnected(connectionInfo);
 };
 
 /**
  * @override {remoting.ApplicationInterface}
  */
 remoting.DesktopRemoting.prototype.onDisconnected_ = function() {
-  var mode = this.getConnectionMode();
-  if (mode === remoting.Application.Mode.IT2ME) {
-    remoting.setMode(remoting.AppMode.CLIENT_SESSION_FINISHED_IT2ME);
-  } else {
-    remoting.setMode(remoting.AppMode.CLIENT_SESSION_FINISHED_ME2ME);
-  }
-  base.dispose(this.connectedView_);
-  this.connectedView_ = null;
+  this.flow_.onDisconnected();
+  this.reset_();
 };
 
 /**
  * @param {!remoting.Error} error
  * @override {remoting.ApplicationInterface}
  */
 remoting.DesktopRemoting.prototype.onConnectionFailed_ = function(error) {
-  var that = this;

[kelvinp, 2015/04/02 23:28:10]

Moved to Me2MeConnectFlow.onConnectionFailed();

-  var onHostListRefresh = function(/** boolean */ success) {
-    if (success) {
-      var connector = that.sessionConnector_;
-      var host = remoting.hostList.getHostForId(connector.getHostId());
-      if (host) {
-        connector.retryConnectMe2Me(host);
-        return;
-      }
-    }
-    that.onError_(error);
-  };
-
-  var mode = this.getConnectionMode();
-  if (error.hasTag(remoting.Error.Tag.HOST_IS_OFFLINE) &&
-      mode === remoting.Application.Mode.ME2ME &&
-      this.refreshHostJidIfOffline_) {
-    this.refreshHostJidIfOffline_ = false;
-
-    // The plugin will be re-created when the host finished refreshing
-    remoting.hostList.refresh(onHostListRefresh);
-  } else {
-    this.onError_(error);
-  }
+  this.flow_.onConnectionFailed(error);
 };
 
 /**
  * @param {!remoting.Error} error The error to be localized and displayed.
  * @override {remoting.ApplicationInterface}
  */
 remoting.DesktopRemoting.prototype.onError_ = function(error) {
   console.error('Connection failed: ' + error.toString());
-  var mode = this.getConnectionMode();
-  base.dispose(this.connectedView_);
-  this.connectedView_ = null;
 
   if (error.hasTag(remoting.Error.Tag.AUTHENTICATION_FAILED)) {
     remoting.setMode(remoting.AppMode.HOME);
     remoting.handleAuthFailureAndRelaunch();
     return;
   }
 
-  // Reset the refresh flag so that the next connection will retry if needed.
-  this.refreshHostJidIfOffline_ = true;
-
-  var errorDiv = document.getElementById('connect-error-message');
-  l10n.localizeElementFromTag(errorDiv, error.getTag());
-
-  if (mode == remoting.Application.Mode.IT2ME) {
-    remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
-  } else {
-    remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_ME2ME);
-  }
+  this.flow_.onError(error);
+  this.reset_();
 };
 
 /**
  * Determine whether or not the app is running in a window.
  * @param {function(boolean):void} callback Callback to receive whether or not
  *     the current tab is running in windowed mode.
  * @private
  */
 remoting.DesktopRemoting.prototype.isWindowed_ = function(callback) {
   /** @param {chrome.Window} win The current window. */
@@ skipping 43 matching lines @@
 
 /**
  * Entry-point for Me2Me connections.
  *
  * @param {string} hostId The unique id of the host.
  * @return {void} Nothing.
  * @private
  */
 remoting.DesktopRemoting.prototype.connectMe2Me_ = function(hostId) {
   var host = remoting.hostList.getHostForId(hostId);
-  var flow = new remoting.Me2MeConnectFlow(this.sessionConnector_, host);
-  flow.start();
+  base.dispose(this.flow_);
+  this.flow_ = new remoting.Me2MeConnectFlow(this.sessionConnector_, host);
+  this.flow_.start();
 };
 
 /**
  * Entry-point for It2Me connections.
  *
  * @private
  */
 remoting.DesktopRemoting.prototype.connectIt2Me_ = function() {
-  var flow = new remoting.It2MeConnectFlow(this.sessionConnector_);
-  flow.start();
+  base.dispose(this.flow_);
+  this.flow_ = new remoting.It2MeConnectFlow(this.sessionConnector_);
+  this.flow_.start();
 };