remoting/webapp/crd/html/dialog_client_session_finished.html - Issue 1054273002: [Webapp Refactor] Implements remoting.Activity.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/webapp/crd/html/dialog_client_session_finished.html

Issue 1054273002: [Webapp Refactor] Implements remoting.Activity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!--	1 <!--

2 Copyright (c) 2014 The Chromium Authors. All rights reserved.	2 Copyright (c) 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6 <div data-ui-mode="home.client.session-finished"	6 <div data-ui-mode="home.client.session-finished"

7 class="message" i18n-content="MESSAGE_SESSION_FINISHED">	7 class="message" i18n-content="MESSAGE_SESSION_FINISHED">

8 </div> <!-- client.session-finished -->	8 </div> <!-- client.session-finished -->

9	9

10 <div data-ui-mode="home.client.connect-failed.it2me home.client.session-finished .it2me"	10 <div data-ui-mode="home.client.connect-failed.it2me home.client.session-finished .it2me"

11 class="button-row">	11 class="button-row">

12 <button id="client-finished-it2me-button"	12 <button id="client-finished-it2me-button"

13 type="button"	13 type="button"

14 i18n-content="OK"	14 i18n-content="OK"

15 autofocus="autofocus">	15 autofocus="autofocus">

16 </button>	16 </button>

17 </div> <!-- connect-failed.it2me session-finished.it2me -->	17 </div> <!-- connect-failed.it2me session-finished.it2me -->

18	18

19 <div data-ui-mode="home.client.connect-failed.me2me home.client.session-finished .me2me"	19 <div data-ui-mode="home.client.connect-failed.me2me home.client.session-finished .me2me"

20 class="button-row">	20 class="button-row">

21 <button id="client-reconnect-button"	21 <button id="client-reconnect-button"

22 type="button"	22 type="button"

23 i18n-content="RETRY"	23 i18n-content="RECONNECT">
	kelvinp 2015/04/02 23:28:09 In today's code, we always change the label to REC In today's code, we always change the label to RECONNECT upon a successful connection, and we never show this UI if the connection failed. I simplified the code by always defaulting it to RECONNECT and same for the other changes in this file.
24 autofocus="autofocus">

25 </button>	24 </button>

26 <button id="client-finished-me2me-button"	25 <button id="client-finished-me2me-button"

27 type="button"	26 type="button"

28 i18n-content="CANCEL">	27 autofocus="autofocus"

	28 i18n-content="OK">

29 </button>	29 </button>

30 </div> <!-- connect-failed.me2me session-finished.me2me -->	30 </div> <!-- connect-failed.me2me session-finished.me2me -->

OLD	NEW