ChannelMojo: Ensure that it always has ScopedIPCSupport

ChannelMojo: Ensure that it always has ScopedIPCSupport

ChannelMojo has ScopedIPCSupport, but it is instantiated only in
in-process mode. This CL lets it always instantiate to make it
clear that ChannelInfo is protected by the ScopedIPCSupport.
It simplifies the relationship between the support object and
the channel, and makes the lifecycle invariant reasonable.

With this change, we no longer need to protect ChannelMojo with
ScopedIPCSupport on its client side. Now it's built-in.

Note that this is a speculative fix of fuzzer generated crash,
where Mojo channel related globals are gone before when channel
mojo is being destroyed.

BUG=473438
R=viettrungluu@chromium.org, rockot@chromium.org

Committed: https://crrev.com/808706e71c213c916815e967e3156cae64d12c00
Cr-Commit-Position: refs/heads/master@{#324308}

Committed: https://crrev.com/00194e78d7abbe83af8aab3e23c49e90d767126f
Cr-Commit-Position: refs/heads/master@{#324488}

[Ken Rockot(use gerrit already), 2015-04-06 23:55:08]

lgtm

[Hajime Morrita, 2015-04-07 20:52:41]

Charlie, could you take a look at this as a content/ OWNER?
It just follows ipc/mojo/ change and removes some code as well.

[Charlie Reis, 2015-04-07 22:23:24]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2015-04-07 22:23:25]

Rubber stamp LGTM for content/.

[Hajime Morrita, 2015-04-07 23:11:04]

Thanks Charlie!
Trung: PTAL at ipc/mojo ?

[viettrungluu, 2015-04-08 20:05:37]

ipc/mojo lgtm

[Hajime Morrita, 2015-04-08 20:38:56]

Thanks! Landing...

[Hajime Morrita, 2015-04-08 20:39:00]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2015-04-08 20:41:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054253005/1

[commit-bot: I haz the power, 2015-04-08 23:42:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-08 23:43:38]

Patchset 1 (id:??) landed as
https://crrev.com/808706e71c213c916815e967e3156cae64d12c00
Cr-Commit-Position: refs/heads/master@{#324308}

[Sorin Jianu, 2015-04-09 16:23:19]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1069943003/ by sorin@chromium.org.

The reason for reverting is: It breaks the lkgr bots for various win ASAN, such
as:
http://build.chromium.org/p/chromium.lkgr/waterfall?builder=Win%20ASan%20Release

[17485/19602] CXX obj\content\test\test_support_content.fake_plugin_service.obj
FAILED: ninja -t msvc -e environment.x86 --
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
/showIncludes /FC
@obj\tools\ipc_fuzzer\message_replay\ipc_fuzzer_replay.replay_process.obj.rsp /c
..\..\tools\ipc_fuzzer\message_replay\replay_process.cc
/Foobj\tools\ipc_fuzzer\message_replay\ipc_fuzzer_replay.replay_process.obj
/Fdobj\tools\ipc_fuzzer\message_replay\ipc_fuzzer_replay.cc.pdb 
..\..\tools\ipc_fuzzer\message_replay\replay_process.cc(96,68) :  error(clang):
too few arguments to function call, expected 3, have 2
        IPC::ChannelMojo::CreateClientFactory(nullptr, channel_name), this,
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                      ^
..\..\ipc/mojo/ipc_channel_mojo.h(80,3) :  note(clang): 'CreateClientFactory'
declared here
  static scoped_ptr<ChannelFactory> CreateClientFactory(
  ^
1 error generated.
clang-cl.exe: warning: falling back to
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\bin\amd64_x86\cl.exe
clang-cl.exe: error: clang frontend command failed with exit code 2 (use -v to
see invocation)
..\..\tools\ipc_fuzzer\message_replay\replay_process.cc(96) : error C2660:
'IPC::ChannelMojo::CreateClientFactory' : function does not take 2 arguments.

[Hajime Morrita, 2015-04-09 18:12:05]

The CQ bit was checked by morrita@chromium.org

[Hajime Morrita, 2015-04-09 18:12:06]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
creis@chromium.org, viettrungluu@chromium.org
Link to the patchset: https://codereview.chromium.org/1054253005/#ps20001
(title: "Fixed the ipc_fuzzer breakage")

[commit-bot: I haz the power, 2015-04-09 18:13:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1054253005/20001

[commit-bot: I haz the power, 2015-04-09 19:43:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-09 19:44:38]

Patchset 2 (id:??) landed as
https://crrev.com/00194e78d7abbe83af8aab3e23c49e90d767126f
Cr-Commit-Position: refs/heads/master@{#324488}