Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1054253004: [DevTools] Input domain implementation in browser. (Closed)

Created:
5 years, 8 months ago by dgozman
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Input domain implementation in browser. BUG=472077 Committed: https://crrev.com/e20f50c297917306f1f438a58ae29e94fb7bc912 Cr-Commit-Position: refs/heads/master@{#323900}

Patch Set 1 #

Patch Set 2 : Fix include #

Patch Set 3 : cleanup #

Total comments: 3

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -40 lines) Patch
M content/browser/devtools/protocol/input_handler.cc View 1 2 3 6 chunks +159 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Could you please take a look?
5 years, 8 months ago (2015-04-03 16:02:32 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1054253004/diff/40001/content/browser/devtools/protocol/input_handler.cc File content/browser/devtools/protocol/input_handler.cc (right): https://codereview.chromium.org/1054253004/diff/40001/content/browser/devtools/protocol/input_handler.cc#newcode47 content/browser/devtools/protocol/input_handler.cc:47: for (size_t i = 0; i < text16.size(); ...
5 years, 8 months ago (2015-04-03 16:54:48 UTC) #3
dgozman
https://codereview.chromium.org/1054253004/diff/40001/content/browser/devtools/protocol/input_handler.cc File content/browser/devtools/protocol/input_handler.cc (right): https://codereview.chromium.org/1054253004/diff/40001/content/browser/devtools/protocol/input_handler.cc#newcode47 content/browser/devtools/protocol/input_handler.cc:47: for (size_t i = 0; i < text16.size(); ++i) ...
5 years, 8 months ago (2015-04-06 09:46:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054253004/60001
5 years, 8 months ago (2015-04-06 09:46:40 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-06 10:46:51 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 10:47:46 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e20f50c297917306f1f438a58ae29e94fb7bc912
Cr-Commit-Position: refs/heads/master@{#323900}

Powered by Google App Engine
This is Rietveld 408576698