Avoid calling the GetSystemMetrics API in the renderer process on Windows to get the scrollbar metr…

content/public/common/renderer_preferences.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/renderer_preferences.h"
 
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/font_render_params.h"
 
 namespace content {
@@ skipping 25 matching lines @@
       report_frame_name_changes(false),
       tap_multiple_targets_strategy(TAP_MULTIPLE_TARGETS_STRATEGY_POPUP),
       disable_client_blocked_error_page(false),
       plugin_fullscreen_allowed(true),
       use_video_overlay_for_embedded_encrypted_video(false),
       use_view_overlay_for_all_video(false),
       caption_font_height(0),
       small_caption_font_height(0),
       menu_font_height(0),
       status_font_height(0),
-      message_font_height(0) {
+      message_font_height(0),
+      vertical_scroll_bar_width_in_dips(0),
+      horizontal_scroll_bar_height_in_dips(0),
+      arrow_bitmap_height_vertical_scroll_bar_in_dips(0),
+      arrow_bitmap_width_horizontal_scroll_bar_in_dips(0) {

[brucedawson, 2015/04/03 17:00:24]

This would be cleaner if we initialized these when they are declared, but for
consistency I agree that we should initialize them here. Tempting to change to
initialize all in the declaration... but no.

 }
 
 RendererPreferences::~RendererPreferences() { }
 
 }  // namespace content