Avoid calling the GetSystemMetrics API in the renderer process on Windows to get the scrollbar metr…

chrome/browser/renderer_preferences_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_preferences_util.h"
 
 #include "base/macros.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
@@ skipping 16 matching lines @@
 
 #if defined(USE_AURA) && defined(OS_LINUX) && !defined(OS_CHROMEOS)
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "ui/views/linux_ui/linux_ui.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/win/win_util.h"
 #include "ui/gfx/platform_font_win.h"
+#include "ui/gfx/win/dpi.h"
 #endif
 
 namespace renderer_preferences_util {
 
 void UpdateFromSystemSettings(content::RendererPreferences* prefs,
                               Profile* profile,
                               content::WebContents* web_contents) {
   const PrefService* pref_service = profile->GetPrefs();
   prefs->accept_languages = pref_service->GetString(prefs::kAcceptLanguages);
   prefs->enable_referrers = pref_service->GetBoolean(prefs::kEnableReferrers);
@@ skipping 91 matching lines @@
   prefs->menu_font_height = gfx::PlatformFontWin::GetFontSize(
       metrics.lfMenuFont);
 
   prefs->status_font_family_name = metrics.lfStatusFont.lfFaceName;
   prefs->status_font_height = gfx::PlatformFontWin::GetFontSize(
       metrics.lfStatusFont);
 
   prefs->message_font_family_name = metrics.lfMessageFont.lfFaceName;
   prefs->message_font_height = gfx::PlatformFontWin::GetFontSize(
       metrics.lfMessageFont);
+
+  prefs->vertical_scroll_bar_width_in_dips =
+      gfx::win::GetSystemMetricsInDIP(SM_CXVSCROLL);
+  prefs->horizontal_scroll_bar_height_in_dips =

[brucedawson, 2015/04/03 17:00:24]

When are SM_CYHSCROLL, SM_CYVSCROLL, and SM_CXHSCROLL used?

[ananta, 2015/04/03 19:17:03]

They are not used as of now. I added those just in case we need them in the
future.

+      gfx::win::GetSystemMetricsInDIP(SM_CYHSCROLL);
+  prefs->arrow_bitmap_height_vertical_scroll_bar_in_dips =
+      gfx::win::GetSystemMetricsInDIP(SM_CYVSCROLL);
+  prefs->arrow_bitmap_width_horizontal_scroll_bar_in_dips =
+      gfx::win::GetSystemMetricsInDIP(SM_CXHSCROLL);

[jam, 2015/04/03 15:08:19]

seems this should be done in content layer instead of chrome so that all content
based browsers get this. same for some of the other stuff above


the only code that should be in this method is setting preferences that need
stuff from the chrome layer (i.e. from prefs)

[ananta, 2015/04/03 19:17:03]

Moved this as well as the font metrics code above to the
RenderViewHostImpl::CreateRenderView function.

 #endif
 }
 
 }  // namespace renderer_preferences_util